Re: [PATCH 3/3] libstdc++: Implement C++20 range adaptors

2020-02-18 Thread Jonathan Wakely
On 18/02/20 21:11 +0100, Stephan Bergmann wrote: On 18/02/2020 12:56, Jonathan Wakely wrote: Does this solve the problem, and work with both compilers? diff --git a/libstdc++-v3/include/std/ranges b/libstdc++-v3/include/std/ranges index b9ac528fdff..481ba75ee5e 100644 --- a/libstdc++-v3/inclu

Re: [PATCH 3/3] libstdc++: Implement C++20 range adaptors

2020-02-18 Thread Stephan Bergmann
On 18/02/2020 12:56, Jonathan Wakely wrote: Does this solve the problem, and work with both compilers? diff --git a/libstdc++-v3/include/std/ranges b/libstdc++-v3/include/std/ranges index b9ac528fdff..481ba75ee5e 100644 --- a/libstdc++-v3/include/std/ranges +++ b/libstdc++-v3/include/std/range

Re: [PATCH 3/3] libstdc++: Implement C++20 range adaptors

2020-02-18 Thread Jonathan Wakely
On 17/02/20 20:20 -0500, Patrick Palka wrote: Hi Stephan, On Mon, 17 Feb 2020, Stephan Bergmann wrote: On 04/02/2020 03:07, Patrick Palka wrote: > This patch implements [range.adaptors]. It also includes the changes from > P3280 > and P3278 and P3323, without which many standard examples won'

Re: [PATCH 3/3] libstdc++: Implement C++20 range adaptors

2020-02-18 Thread Jonathan Wakely
On 17/02/20 23:07 +0100, Stephan Bergmann wrote: On 04/02/2020 03:07, Patrick Palka wrote: This patch implements [range.adaptors]. It also includes the changes from P3280 and P3278 and P3323, without which many standard examples won't work. I see that with this

Re: [PATCH 3/3] libstdc++: Implement C++20 range adaptors

2020-02-17 Thread Stephan Bergmann
On 18/02/2020 02:20, Patrick Palka wrote: On Mon, 17 Feb 2020, Stephan Bergmann wrote: On 04/02/2020 03:07, Patrick Palka wrote: This patch implements [range.adaptors]. It also includes the changes from P3280 and P3278 and P3323, without which many standard examples won't work. I see that wi

Re: [PATCH 3/3] libstdc++: Implement C++20 range adaptors

2020-02-17 Thread Patrick Palka
Hi Stephan, On Mon, 17 Feb 2020, Stephan Bergmann wrote: > On 04/02/2020 03:07, Patrick Palka wrote: > > This patch implements [range.adaptors]. It also includes the changes from > > P3280 > > and P3278 and P3323, without which many standard examples won't work. > > I see that with this >

Re: [PATCH 3/3] libstdc++: Implement C++20 range adaptors

2020-02-17 Thread Stephan Bergmann
On 04/02/2020 03:07, Patrick Palka wrote: This patch implements [range.adaptors]. It also includes the changes from P3280 and P3278 and P3323, without which many standard examples won't work. I see that with this

Re: [PATCH 3/3] libstdc++: Implement C++20 range adaptors

2020-02-07 Thread Patrick Palka
On Fri, 7 Feb 2020, Jonathan Wakely wrote: > On 06/02/20 18:53 -0500, Patrick Palka wrote: > > On Thu, 6 Feb 2020, Jonathan Wakely wrote: > > > > +#ifdef __cpp_lib_threeway_comparison > > > > > > This macro is mispelled, should be three_way with an underscore. > > > > Oops! It looks like it's a

Re: [PATCH 3/3] libstdc++: Implement C++20 range adaptors

2020-02-07 Thread Jonathan Wakely
On 06/02/20 18:53 -0500, Patrick Palka wrote: On Thu, 6 Feb 2020, Jonathan Wakely wrote: > +#ifdef __cpp_lib_threeway_comparison This macro is mispelled, should be three_way with an underscore. Oops! It looks like it's also mispelled in the definition of iota_view earlier in this file. Oop

Re: [PATCH 3/3] libstdc++: Implement C++20 range adaptors

2020-02-06 Thread Patrick Palka
On Thu, 6 Feb 2020, Jonathan Wakely wrote: > On 03/02/20 21:07 -0500, Patrick Palka wrote: > > This patch implements [range.adaptors]. It also includes the changes from > > P3280 > > and P3278 and P3323, without which many standard examples won't work. > > > > The implementation is mostly dictat

Re: [PATCH 3/3] libstdc++: Implement C++20 range adaptors

2020-02-06 Thread Jonathan Wakely
On 03/02/20 21:07 -0500, Patrick Palka wrote: This patch implements [range.adaptors]. It also includes the changes from P3280 and P3278 and P3323, without which many standard examples won't work. The implementation is mostly dictated by the spec and there was not much room for implementation di

[PATCH 3/3] libstdc++: Implement C++20 range adaptors

2020-02-03 Thread Patrick Palka
This patch implements [range.adaptors]. It also includes the changes from P3280 and P3278 and P3323, without which many standard examples won't work. The implementation is mostly dictated by the spec and there was not much room for implementation discretion. The most interesting part that was no