Re: [PATCH 3/14] Add new optabs for reducing vectors to scalars

2014-09-22 Thread Richard Biener
On Mon, Sep 22, 2014 at 3:26 PM, Alan Lawrence wrote: > Richard Biener wrote: >> >> >> scalar_reduc_to_vector misses a comment. > > > Ok to reuse the comment in optabs.h in optabs.c also? Sure. >> I wonder if at the end we wouldn't transition all backends and then >> renaming reduc_*_scal_optab

Re: [PATCH 3/14] Add new optabs for reducing vectors to scalars

2014-09-22 Thread Alan Lawrence
Richard Biener wrote: scalar_reduc_to_vector misses a comment. Ok to reuse the comment in optabs.h in optabs.c also? I wonder if at the end we wouldn't transition all backends and then renaming reduc_*_scal_optab back to reduc_*_optab makes sense. Yes, that sounds like a plan, the _scal is

Re: [PATCH 3/14] Add new optabs for reducing vectors to scalars

2014-09-22 Thread Richard Biener
On Thu, Sep 18, 2014 at 1:54 PM, Alan Lawrence wrote: > These match their corresponding tree codes, by taking a vector and returning > a scalar; this is more architecturally neutral than the (somewhat loosely > defined) previous optab that took a vector and returned a vector with the > result in t

[PATCH 3/14] Add new optabs for reducing vectors to scalars

2014-09-18 Thread Alan Lawrence
These match their corresponding tree codes, by taking a vector and returning a scalar; this is more architecturally neutral than the (somewhat loosely defined) previous optab that took a vector and returned a vector with the result in the least significant bits (i.e. element 0 for little-endian