Re: [PATCH 2/9] operand_equal_p: add support for FIELD_DECL

2019-09-11 Thread Martin Liška
On 8/16/19 2:09 PM, Jan Hubicka wrote: >> On Thu, Aug 15, 2019 at 4:17 PM Jan Hubicka wrote: >>> On Tue, Aug 6, 2019 at 5:44 PM Martin Liska wrote: > > > gcc/ChangeLog: So I suppose this isn't to call operand_equal_p on two FIELD_DECLs but to make two COMPONENT_REF

Re: [PATCH 2/9] operand_equal_p: add support for FIELD_DECL

2019-08-16 Thread Jan Hubicka
> On Thu, Aug 15, 2019 at 4:17 PM Jan Hubicka wrote: > > > > > On Tue, Aug 6, 2019 at 5:44 PM Martin Liska wrote: > > > > > > > > > > > > gcc/ChangeLog: > > > > > > So I suppose this isn't to call operand_equal_p on two FIELD_DECLs > > > but to make two COMPONENT_REFs "more equal"? If so I then

Re: [PATCH 2/9] operand_equal_p: add support for FIELD_DECL

2019-08-16 Thread Richard Biener
On Thu, Aug 15, 2019 at 4:17 PM Jan Hubicka wrote: > > > On Tue, Aug 6, 2019 at 5:44 PM Martin Liska wrote: > > > > > > > > > gcc/ChangeLog: > > > > So I suppose this isn't to call operand_equal_p on two FIELD_DECLs > > but to make two COMPONENT_REFs "more equal"? If so I then > > yes. The patch

Re: [PATCH 2/9] operand_equal_p: add support for FIELD_DECL

2019-08-15 Thread Jan Hubicka
> On Tue, Aug 6, 2019 at 5:44 PM Martin Liska wrote: > > > > > > gcc/ChangeLog: > > So I suppose this isn't to call operand_equal_p on two FIELD_DECLs > but to make two COMPONENT_REFs "more equal"? If so I then yes. The patch originates from my original patchset I believe and it is what ICF doe

Re: [PATCH 2/9] operand_equal_p: add support for FIELD_DECL

2019-08-07 Thread Richard Biener
On Tue, Aug 6, 2019 at 5:44 PM Martin Liska wrote: > > > gcc/ChangeLog: So I suppose this isn't to call operand_equal_p on two FIELD_DECLs but to make two COMPONENT_REFs "more equal"? If so I then I suggest to make this change "local" to the COMPONENT_REF handling. This also interacts with path-

[PATCH 2/9] operand_equal_p: add support for FIELD_DECL

2019-08-06 Thread Martin Liska
gcc/ChangeLog: 2019-07-24 Martin Liska * fold-const.c (operand_equal_p): Support FIELD_DECL as well. * tree.c (add_expr): Hast DECL_FIELD_OFFSET and DECL_FIELD_BIT_OFFSET for FIELD_DECL. gcc/testsuite/ChangeLog: 2019-07-24 Martin Liska * gcc.dg/ve