Re: [PATCH 2/7] [OpenACC] Adjust dynamic reference count semantics

2020-06-05 Thread Julian Brown
On Wed, 3 Jun 2020 17:19:47 +0200 Thomas Schwinge wrote: > Hi Julian! > > On 2020-06-03T14:36:14+0200, I wrote: > > On 2020-05-22T15:16:05-0700, Julian Brown > > wrote: > >> This patch adjusts the semantics of dynamic reference counts, as > >> described in the parent email. > > > > Thanks!

[OpenACC] Don't open-code 'gomp_remove_var' in 'acc_unmap_data' (was: [PATCH 2/7] [OpenACC] Adjust dynamic reference count semantics)

2020-06-04 Thread Thomas Schwinge
Hi Julian! On 2020-05-22T15:16:05-0700, Julian Brown wrote: > --- a/libgomp/oacc-mem.c > +++ b/libgomp/oacc-mem.c > @@ -475,14 +475,19 @@ acc_unmap_data (void *h) >gomp_mutex_unlock (&acc_dev->lock); >gomp_fatal ("cannot unmap target block"); > } > - else if (tgt->refcount

Re: [PATCH 2/7] [OpenACC] Adjust dynamic reference count semantics

2020-06-03 Thread Thomas Schwinge
Hi Julian! On 2020-06-03T14:36:14+0200, I wrote: > On 2020-05-22T15:16:05-0700, Julian Brown wrote: >> This patch adjusts the semantics of dynamic reference counts, as described >> in the parent email. > > Thanks! > > A few questions, but no need to send an updated patch. > >> --- a/libgomp/oacc-

Re: [PATCH 2/7] [OpenACC] Adjust dynamic reference count semantics

2020-06-03 Thread Thomas Schwinge
Hi Julian! On 2020-05-22T15:16:05-0700, Julian Brown wrote: > This patch adjusts the semantics of dynamic reference counts, as described > in the parent email. Thanks! A few questions, but no need to send an updated patch. > --- a/libgomp/oacc-mem.c > +++ b/libgomp/oacc-mem.c > @@ -1018,13 +1

[PATCH 2/7] [OpenACC] Adjust dynamic reference count semantics

2020-05-22 Thread Julian Brown
This patch adjusts the semantics of dynamic reference counts, as described in the parent email. There are also two new test cases derived from Thomas's test in the email: https://gcc.gnu.org/pipermail/gcc-patches/2020-May/546166.html that work now. OK? Julian ChangeLog libgomp/