Re: [PATCH 2/6] ifcvt: Allow constants operands in noce_convert_multiple_sets.

2018-12-01 Thread Jeff Law
On 11/15/18 4:34 AM, Robin Dapp wrote: >> This may ultimately be too simplistic. There are targets where some >> constants are OK, but others may not be. By checking the predicate >> like this I think you can cause over-aggressive if-conversion if the >> target allows a range of integers in the

Re: [PATCH 2/6] ifcvt: Allow constants operands in noce_convert_multiple_sets.

2018-11-15 Thread Robin Dapp
> This may ultimately be too simplistic. There are targets where some > constants are OK, but others may not be. By checking the predicate > like this I think you can cause over-aggressive if-conversion if the > target allows a range of integers in the expander's operand predicate, > but allows

Re: [PATCH 2/6] ifcvt: Allow constants operands in noce_convert_multiple_sets.

2018-11-14 Thread Jeff Law
On 11/14/18 6:07 AM, Robin Dapp wrote: > This patch checks whether the current target supports conditional moves > with immediate then/else operands and allows noce_convert_multiple_sets > to deal with constants subsequently. > Also, minor refactoring is performed. > > -- > > gcc/ChangeLog: > >

[PATCH 2/6] ifcvt: Allow constants operands in noce_convert_multiple_sets.

2018-11-14 Thread Robin Dapp
This patch checks whether the current target supports conditional moves with immediate then/else operands and allows noce_convert_multiple_sets to deal with constants subsequently. Also, minor refactoring is performed. -- gcc/ChangeLog: 2018-11-14 Robin Dapp * ifcvt.c (have_const_cmo