Re: [PATCH 2/5] omp-low: implement SIMT privatization, part 1

2017-04-20 Thread Jakub Jelinek
On Thu, Apr 20, 2017 at 07:37:13PM +0300, Alexander Monakov wrote: > On Thu, 20 Apr 2017, Jakub Jelinek wrote: > > > This wasn't caught in testing, as apparently all testcases that have > > > target > > > simd loops with linear/lastprivate clauses also have the corresponding > > > variables > > >

Re: [PATCH 2/5] omp-low: implement SIMT privatization, part 1

2017-04-20 Thread Alexander Monakov
On Thu, 20 Apr 2017, Jakub Jelinek wrote: > > This wasn't caught in testing, as apparently all testcases that have target > > simd loops with linear/lastprivate clauses also have the corresponding > > variables > > mentioned in target map clause, which makes them addressable (is that > > necessar

Re: [PATCH 2/5] omp-low: implement SIMT privatization, part 1

2017-04-20 Thread Jakub Jelinek
On Fri, Mar 31, 2017 at 06:38:09PM +0300, Alexander Monakov wrote: > I've noticed while re-reading that this patch incorrectly handled SIMT case > in lower_lastprivate_clauses. The code was changed to look for variables > with "omp simt private" attribute, and was left under > 'simduid && DECL_HAS

Re: [PATCH 2/5] omp-low: implement SIMT privatization, part 1

2017-03-31 Thread Alexander Monakov
Hello Jakub, I've noticed while re-reading that this patch incorrectly handled SIMT case in lower_lastprivate_clauses. The code was changed to look for variables with "omp simt private" attribute, and was left under 'simduid && DECL_HAS_VALUE_EXPR_P (new_var)' condition. This effectively constra

Re: [PATCH 2/5] omp-low: implement SIMT privatization, part 1

2017-03-23 Thread Jakub Jelinek
On Wed, Mar 22, 2017 at 06:46:32PM +0300, Alexander Monakov wrote: > This patch adjusts privatization in OpenMP SIMD loops lowered for SIMT > targets. > At lowering time, private variables receive "omp simt private" attribute, get > mentioned in argument list of GOMP_SIMT_ENTER function, and get a

[PATCH 2/5] omp-low: implement SIMT privatization, part 1

2017-03-22 Thread Alexander Monakov
This patch adjusts privatization in OpenMP SIMD loops lowered for SIMT targets. At lowering time, private variables receive "omp simt private" attribute, get mentioned in argument list of GOMP_SIMT_ENTER function, and get a clobbering assignment just prior to GOMP_SIMT_EXIT function. The following