Re: [PATCH 2/5] c_diagnostic_ignored_function hack

2014-06-19 Thread Tom Tromey
Joseph> I'd say this global actually belongs somewhere in the Joseph> diagnostic_context (i.e., instead of the Joseph> diagnostic_context_auxiliary_data (DC) actually being a tree as Joseph> it is at present, it should point to a structure with whatever Joseph> extra information clients wish to use

Re: [PATCH 2/5] c_diagnostic_ignored_function hack

2014-06-09 Thread Tom Tromey
> "Manuel" == Manuel López-Ibáñez writes: Tom> This patch makes it possible to suppress the function-name display in Tom> a straightforward way: it adds a new global which the plugin can set Tom> to declare the name of the dummy function. Manuel> Otherwise, why not override the lang_hook its

Re: [PATCH 2/5] c_diagnostic_ignored_function hack

2014-05-16 Thread Tom Tromey
Jeff> BTW, didn't see patch #5 of the series. Maybe it was too big. I will try to resend it compressed. Tom

Re: [PATCH 2/5] c_diagnostic_ignored_function hack

2014-05-16 Thread Jeff Law
On 05/16/14 09:26, Tom Tromey wrote: In the typical case, when compiling a snippet of user code, gdb wraps the user's text in a dummy function. It's somewhat odd for users if an error in their code is mentioned as coming from this dummy function. This patch makes it possible to suppress the fun

Re: [PATCH 2/5] c_diagnostic_ignored_function hack

2014-05-16 Thread Manuel López-Ibáñez
> This patch makes it possible to suppress the function-name display in > a straightforward way: it adds a new global which the plugin can set > to declare the name of the dummy function. > > This patch seems like a bit of a hack, but there didn't seem to be a > notably cleaner approach. Can't you

Re: [PATCH 2/5] c_diagnostic_ignored_function hack

2014-05-16 Thread Joseph S. Myers
On Fri, 16 May 2014, Tom Tromey wrote: > In the typical case, when compiling a snippet of user code, gdb wraps > the user's text in a dummy function. > > It's somewhat odd for users if an error in their code is mentioned as > coming from this dummy function. > > This patch makes it possible to s

[PATCH 2/5] c_diagnostic_ignored_function hack

2014-05-16 Thread Tom Tromey
In the typical case, when compiling a snippet of user code, gdb wraps the user's text in a dummy function. It's somewhat odd for users if an error in their code is mentioned as coming from this dummy function. This patch makes it possible to suppress the function-name display in a straightforward