Re: [PATCH 2/5] Convert Walloca pass to RANGE_QUERY(cfun).

2021-05-27 Thread Aldy Hernandez via Gcc-patches
On x86-32 warn_ptrdiff_anti_range_add() and warn_int_anti_range() degrade to the same function so ICF is folding the latter into a call into the former. This is causing no warnings to be emitted for warn_int_anti_range. Fixed by passing -fno-ipa-icf to the test. Long term, we really should be fi

Re: [PATCH 2/5] Convert Walloca pass to RANGE_QUERY(cfun).

2021-05-27 Thread Christophe Lyon via Gcc-patches
Hi, On Tue, 25 May 2021 at 18:17, Aldy Hernandez via Gcc-patches wrote: > > Adjustments per discussion. > > OK pending tests? > The xfail removal causes failures on 32 bits platforms (eg arm, or aarch64 with -mabi=ilp32): FAIL: gcc.dg/Wstringop-overflow-55.c pr? (test for warnings, line 86)

Re: [PATCH 2/5] Convert Walloca pass to RANGE_QUERY(cfun).

2021-05-25 Thread Martin Sebor via Gcc-patches
On 5/25/21 10:17 AM, Aldy Hernandez via Gcc-patches wrote: Adjustments per discussion. OK pending tests? Aldy I have no concern with the alloca changes. The xfail removals from the two tests in this patch (a nice improvement) don't seem to be related to alloca so I'd expect them to fail unle

Re: [PATCH 2/5] Convert Walloca pass to RANGE_QUERY(cfun).

2021-05-25 Thread Jeff Law via Gcc-patches
On 5/25/2021 10:17 AM, Aldy Hernandez wrote: Adjustments per discussion. OK pending tests? The latest revision of #2-#5 are OK once #1 is ACK'd. Jeff

Re: [PATCH 2/5] Convert Walloca pass to RANGE_QUERY(cfun).

2021-05-25 Thread Aldy Hernandez via Gcc-patches
Adjustments per discussion. OK pending tests? Aldy >From 97bedf7dc0a7860802461b5fd3e72b687076ae30 Mon Sep 17 00:00:00 2001 From: Aldy Hernandez Date: Wed, 19 May 2021 18:27:47 +0200 Subject: [PATCH 3/5] Convert Walloca pass to get_range_query. This patch converts the Walloca pass to use an on-

Re: [PATCH 2/5] Convert Walloca pass to RANGE_QUERY(cfun).

2021-05-25 Thread Richard Biener via Gcc-patches
On Fri, May 21, 2021 at 2:34 PM Aldy Hernandez via Gcc-patches wrote: > > This patch converts the Walloca pass to use an on-demand ranger > accesible with RANGE_QUERY instead of having to create a ranger and pass > it around. > > Tested on x86-64 Linux. > > OK? > > gcc/ChangeLog: > > * gim

[PATCH 2/5] Convert Walloca pass to RANGE_QUERY(cfun).

2021-05-21 Thread Aldy Hernandez via Gcc-patches
This patch converts the Walloca pass to use an on-demand ranger accesible with RANGE_QUERY instead of having to create a ranger and pass it around. Tested on x86-64 Linux. OK? gcc/ChangeLog: * gimple-ssa-warn-alloca.c (alloca_call_type): Use RANGE_QUERY instead of query argument