Re: [PATCH 2/4] Switch other switch expansion methods into classes.

2018-06-22 Thread Jeff Law
On 06/22/2018 04:32 AM, Martin Liška wrote: > On 06/20/2018 05:16 PM, Jeff Law wrote: >> On 06/20/2018 05:25 AM, Steven Bosscher wrote: >>> On Tue, Jun 12, 2018 at 10:44 PM, Jeff Law wrote: On 06/05/2018 01:15 AM, marxin wrote: > + The definition of "much bigger" depends on whether we

Re: [PATCH 2/4] Switch other switch expansion methods into classes.

2018-06-22 Thread Martin Liška
On 06/20/2018 05:16 PM, Jeff Law wrote: > On 06/20/2018 05:25 AM, Steven Bosscher wrote: >> On Tue, Jun 12, 2018 at 10:44 PM, Jeff Law wrote: >>> On 06/05/2018 01:15 AM, marxin wrote: + The definition of "much bigger" depends on whether we are + optimizing for size or for spe

Re: [PATCH 2/4] Switch other switch expansion methods into classes.

2018-06-20 Thread Jeff Law
On 06/20/2018 09:20 AM, Jakub Jelinek wrote: > On Wed, Jun 20, 2018 at 09:15:08AM -0600, Jeff Law wrote: >>> Thank you for the trust. I tried to split it into multiple patches, but >>> it wasn't readable enough. >> Yea, it can be painful to find the right way to structure a series. In >> fact, I'm

Re: [PATCH 2/4] Switch other switch expansion methods into classes.

2018-06-20 Thread Jakub Jelinek
On Wed, Jun 20, 2018 at 09:15:08AM -0600, Jeff Law wrote: > > Thank you for the trust. I tried to split it into multiple patches, but > > it wasn't readable enough. > Yea, it can be painful to find the right way to structure a series. In > fact, I'm going to be faced with that shortly for a target

Re: [PATCH 2/4] Switch other switch expansion methods into classes.

2018-06-20 Thread Jeff Law
On 06/20/2018 05:25 AM, Steven Bosscher wrote: > On Tue, Jun 12, 2018 at 10:44 PM, Jeff Law wrote: >> On 06/05/2018 01:15 AM, marxin wrote: >>> >>> + The definition of "much bigger" depends on whether we are >>> + optimizing for size or for speed. If the former, the maximum >>> + ratio

Re: [PATCH 2/4] Switch other switch expansion methods into classes.

2018-06-20 Thread Jeff Law
On 06/20/2018 02:47 AM, Martin Liška wrote: > On 06/12/2018 10:44 PM, Jeff Law wrote: >> On 06/05/2018 01:15 AM, marxin wrote: >>> gcc/ChangeLog: >>> >>> 2018-06-07 Martin Liska >>> >>> * tree-switch-conversion.c (switch_conversion::collect): >>> Record m_uniq property. >>> (swit

Re: [PATCH 2/4] Switch other switch expansion methods into classes.

2018-06-20 Thread Steven Bosscher
On Tue, Jun 12, 2018 at 10:44 PM, Jeff Law wrote: > On 06/05/2018 01:15 AM, marxin wrote: >> >> + The definition of "much bigger" depends on whether we are >> + optimizing for size or for speed. If the former, the maximum >> + ratio range/count = 3, because this was found to be the opt

Re: [PATCH 2/4] Switch other switch expansion methods into classes.

2018-06-20 Thread Martin Liška
On 06/12/2018 10:44 PM, Jeff Law wrote: > On 06/05/2018 01:15 AM, marxin wrote: >> gcc/ChangeLog: >> >> 2018-06-07 Martin Liska >> >> * tree-switch-conversion.c (switch_conversion::collect): >> Record m_uniq property. >> (switch_conversion::expand): Bail out for special conditi

Re: [PATCH 2/4] Switch other switch expansion methods into classes.

2018-06-12 Thread Jeff Law
On 06/05/2018 01:15 AM, marxin wrote: > gcc/ChangeLog: > > 2018-06-07 Martin Liska > > * tree-switch-conversion.c (switch_conversion::collect): > Record m_uniq property. > (switch_conversion::expand): Bail out for special conditions. > (group_cluster::~group_cluster):

[PATCH 2/4] Switch other switch expansion methods into classes.

2018-06-08 Thread marxin
gcc/ChangeLog: 2018-06-07 Martin Liska * tree-switch-conversion.c (switch_conversion::collect): Record m_uniq property. (switch_conversion::expand): Bail out for special conditions. (group_cluster::~group_cluster): New. (group_cluster::group_cluster): L