Re: [PATCH 2/3] aarch64: Add support for moving fpm system register

2024-07-24 Thread Claudio Bantaloukas
On 22/07/2024 11:07, Alex Coplan wrote: > Hi Claudio, > > I've left a couple of small comments below. > > On 22/07/2024 09:30, Claudio Bantaloukas wrote: --8<- >> >> @@ -1505,6 +1513,8 @@ (define_insn_and_split "*movdi_aarch64" >>[w, w ; fmov , fp , 4] fmov\t%d0, %d1 >>

Re: [PATCH 2/3] aarch64: Add support for moving fpm system register

2024-07-23 Thread Claudio Bantaloukas
On 22/07/2024 11:07, Alex Coplan wrote: > Hi Claudio, > > I've left a couple of small comments below. > > On 22/07/2024 09:30, Claudio Bantaloukas wrote: >> >> Unlike most system registers, fpmr can be heavily written to in code that >> exercises the fp8 functionality. That is because every fp8

Re: [PATCH 2/3] aarch64: Add support for moving fpm system register

2024-07-23 Thread Claudio Bantaloukas
On 22/07/2024 10:51, Kyrylo Tkachov wrote: > Hi Claudio, > >> On 22 Jul 2024, at 11:30, Claudio Bantaloukas >> wrote: >> >> External email: Use caution opening links or attachments >> >> >> Unlike most system registers, fpmr can be heavily written to in code that >> exercises the fp8 functiona

Re: [PATCH 2/3] aarch64: Add support for moving fpm system register

2024-07-22 Thread Alex Coplan
Hi Claudio, I've left a couple of small comments below. On 22/07/2024 09:30, Claudio Bantaloukas wrote: > > Unlike most system registers, fpmr can be heavily written to in code that > exercises the fp8 functionality. That is because every fp8 instrinsic call > can potentially change the value of

Re: [PATCH 2/3] aarch64: Add support for moving fpm system register

2024-07-22 Thread Kyrylo Tkachov
Hi Claudio, > On 22 Jul 2024, at 11:30, Claudio Bantaloukas > wrote: > > External email: Use caution opening links or attachments > > > Unlike most system registers, fpmr can be heavily written to in code that > exercises the fp8 functionality. That is because every fp8 instrinsic call > can

[PATCH 2/3] aarch64: Add support for moving fpm system register

2024-07-22 Thread Claudio Bantaloukas
Unlike most system registers, fpmr can be heavily written to in code that exercises the fp8 functionality. That is because every fp8 instrinsic call can potentially change the value of fpmr. Rather than just use a an unspec, we treat the fpmr system register like all other registers and use a move