Re: [PATCH 2/3] Stub implementation of unwinding for AMD GCN.

2019-06-19 Thread Andrew Stubbs
On 19/06/2019 17:04, Jeff Law wrote: On 6/19/19 2:58 AM, Andrew Stubbs wrote: Ping. I can probably approve this myself, as it only affects GCN, but I'd appreciate a second opinion. Similarly this is fine to self-approve. Thanks. Sorry, same again, I meant I'd like another opinion on the pat

Re: [PATCH 2/3] Stub implementation of unwinding for AMD GCN.

2019-06-19 Thread Jeff Law
On 6/19/19 2:58 AM, Andrew Stubbs wrote: > Ping. > > I can probably approve this myself, as it only affects GCN, but I'd > appreciate a second opinion. Similarly this is fine to self-approve. Thanks. Jeff

Re: [PATCH 2/3] Stub implementation of unwinding for AMD GCN.

2019-06-19 Thread Andrew Stubbs
Ping. I can probably approve this myself, as it only affects GCN, but I'd appreciate a second opinion. Thanks Andrew On 07/06/2019 15:40, Andrew Stubbs wrote: This patch provides the "_Unwind_Backtrace" and "_Unwind_GetIPInfo" symbols required to link programs using libgfortran. I do not

[PATCH 2/3] Stub implementation of unwinding for AMD GCN.

2019-06-07 Thread Andrew Stubbs
This patch provides the "_Unwind_Backtrace" and "_Unwind_GetIPInfo" symbols required to link programs using libgfortran. I do not wish to implement proper backtracing at this time (I have other things to work on), and IIUC none of the existing implementations will Just Work. OK to commit? -