Re: [PATCH 2/3] MIPS: use mips_isa enum instead hardcoded numbers

2021-08-29 Thread YunQiang Su
Xi Ruoyao 于2021年8月29日周日 下午1:54写道: > > On Sat, 2021-08-28 at 08:05 -0400, YunQiang Su wrote: > > Currently mips-cpu.defs and mips.h are using hardcoded numbers > > for isa level. > > > > Let's replace them with more readable enum mips_isa. > > Good, but there is something like "mips_isa_rev >= 32 &

Re: [PATCH 2/3] MIPS: use mips_isa enum instead hardcoded numbers

2021-08-28 Thread Xi Ruoyao via Gcc-patches
On Sat, 2021-08-28 at 08:05 -0400, YunQiang Su wrote: > Currently mips-cpu.defs and mips.h are using hardcoded numbers > for isa level. > > Let's replace them with more readable enum mips_isa. Good, but there is something like "mips_isa_rev >= 32 && mips_isa_rev < 64" in mips.h and netbsd.h. Not

[PATCH 2/3] MIPS: use mips_isa enum instead hardcoded numbers

2021-08-28 Thread YunQiang Su
Currently mips-cpu.defs and mips.h are using hardcoded numbers for isa level. Let's replace them with more readable enum mips_isa. gcc/ChangeLog: * config/mips/mips.md: define_enum "mips_isa". * config/mips/mips.h (struct mips_cpu_info): use enum instead of int for 'isa'