Re: [PATCH 2/2]middle-end: Support recognition of three-way max/min.

2022-08-03 Thread H.J. Lu via Gcc-patches
To: Tamar Christina > > > Cc: Richard Biener ; ja...@redhat.com; nd > > > ; gcc-patches@gcc.gnu.org > > > Subject: Re: [PATCH 2/2]middle-end: Support recognition of three-way > > > max/min. > > > > > > On Tue, Aug 2, 2022 at 10:33 AM Tamar Christina via Gcc

RE: [PATCH 2/2]middle-end: Support recognition of three-way max/min.

2022-08-03 Thread Richard Biener via Gcc-patches
; Subject: Re: [PATCH 2/2]middle-end: Support recognition of three-way > > max/min. > > > > On Tue, Aug 2, 2022 at 10:33 AM Tamar Christina via Gcc-patches > patc...@gcc.gnu.org> wrote: > > > > > > > > > > When this function replaces the edge it

RE: [PATCH 2/2]middle-end: Support recognition of three-way max/min.

2022-08-03 Thread Tamar Christina via Gcc-patches
> -Original Message- > From: Richard Biener > Sent: Tuesday, August 2, 2022 10:11 AM > To: Tamar Christina > Cc: Richard Biener ; ja...@redhat.com; nd > ; gcc-patches@gcc.gnu.org > Subject: Re: [PATCH 2/2]middle-end: Support recognition of three-way > max/min.

Re: [PATCH 2/2]middle-end: Support recognition of three-way max/min.

2022-08-02 Thread Richard Biener via Gcc-patches
On Tue, Aug 2, 2022 at 10:33 AM Tamar Christina via Gcc-patches wrote: > > > > > > When this function replaces the edge it doesn't seem to update the > > > > dominators. > > > > > Since It's replacing the middle BB we then end up with an error > > > > > > > > > > gcc/testsuite/gcc.dg/tree-ssa/minm

RE: [PATCH 2/2]middle-end: Support recognition of three-way max/min.

2022-08-02 Thread Tamar Christina via Gcc-patches
> > > > When this function replaces the edge it doesn't seem to update the > > > dominators. > > > > Since It's replacing the middle BB we then end up with an error > > > > > > > > gcc/testsuite/gcc.dg/tree-ssa/minmax-14.c:17:1: error: dominator > > > > of 5 should be 4, not 2 > > > > > > > > durin

RE: [PATCH 2/2]middle-end: Support recognition of three-way max/min.

2022-07-27 Thread Richard Biener via Gcc-patches
On Wed, 27 Jul 2022, Tamar Christina wrote: > > -Original Message- > > From: Richard Biener > > Sent: Tuesday, July 12, 2022 2:19 PM > > To: Tamar Christina > > Cc: gcc-patches@gcc.gnu.org; nd ; ja...@redhat.com > > Subject: RE: [PATCH 2/2]middle-e

RE: [PATCH 2/2]middle-end: Support recognition of three-way max/min.

2022-07-27 Thread Tamar Christina via Gcc-patches
> -Original Message- > From: Richard Biener > Sent: Tuesday, July 12, 2022 2:19 PM > To: Tamar Christina > Cc: gcc-patches@gcc.gnu.org; nd ; ja...@redhat.com > Subject: RE: [PATCH 2/2]middle-end: Support recognition of three-way > max/min. > > On Tue, 5 Jul

RE: [PATCH 2/2]middle-end: Support recognition of three-way max/min.

2022-07-12 Thread Richard Biener via Gcc-patches
On Tue, 5 Jul 2022, Tamar Christina wrote: > > > } > > > + else if (EDGE_SUCC (bb1, 0)->dest == EDGE_SUCC (bb2, 0)->dest > > > +&& single_succ_p (bb1) > > > +&& single_succ_p (bb2) > > > +&& single_pred_p (bb1) > > > +&& single_pred_p (bb2) > > > +&&

RE: [PATCH 2/2]middle-end: Support recognition of three-way max/min.

2022-07-12 Thread Tamar Christina via Gcc-patches
ping > -Original Message- > From: Tamar Christina > Sent: Tuesday, July 5, 2022 4:26 PM > To: Richard Biener > Cc: gcc-patches@gcc.gnu.org; nd ; ja...@redhat.com > Subject: RE: [PATCH 2/2]middle-end: Support recognition of three-way > max/min. > > > >

RE: [PATCH 2/2]middle-end: Support recognition of three-way max/min.

2022-07-05 Thread Tamar Christina via Gcc-patches
> > } > > + else if (EDGE_SUCC (bb1, 0)->dest == EDGE_SUCC (bb2, 0)->dest > > + && single_succ_p (bb1) > > + && single_succ_p (bb2) > > + && single_pred_p (bb1) > > + && single_pred_p (bb2) > > + && single_succ_p (EDGE_SUCC (bb1, 0)->dest)) > >

RE: [PATCH 2/2]middle-end: Support recognition of three-way max/min.

2022-06-27 Thread Richard Biener via Gcc-patches
On Tue, 21 Jun 2022, Tamar Christina wrote: > > -Original Message- > > From: Richard Biener > > Sent: Tuesday, June 21, 2022 2:15 PM > > To: Tamar Christina > > Cc: gcc-patches@gcc.gnu.org; nd ; ja...@redhat.com > > Subject: RE: [PATCH 2/2]middle-e

RE: [PATCH 2/2]middle-end: Support recognition of three-way max/min.

2022-06-21 Thread Tamar Christina via Gcc-patches
> -Original Message- > From: Richard Biener > Sent: Tuesday, June 21, 2022 2:15 PM > To: Tamar Christina > Cc: gcc-patches@gcc.gnu.org; nd ; ja...@redhat.com > Subject: RE: [PATCH 2/2]middle-end: Support recognition of three-way > max/min. > > On Mon, 20 Jun

RE: [PATCH 2/2]middle-end: Support recognition of three-way max/min.

2022-06-21 Thread Richard Biener via Gcc-patches
On Mon, 20 Jun 2022, Tamar Christina wrote: > > -Original Message- > > From: Richard Biener > > Sent: Monday, June 20, 2022 9:36 AM > > To: Tamar Christina > > Cc: gcc-patches@gcc.gnu.org; nd ; ja...@redhat.com > > Subject: Re: [PATCH 2/2]middle-e

RE: [PATCH 2/2]middle-end: Support recognition of three-way max/min.

2022-06-21 Thread Tamar Christina via Gcc-patches
> -Original Message- > From: Andrew Pinski > Sent: Tuesday, June 21, 2022 12:16 AM > To: Tamar Christina > Cc: GCC Patches ; Jakub Jelinek > ; nd ; Richard Guenther > > Subject: Re: [PATCH 2/2]middle-end: Support recognition of three-way > max/min. > >

Re: [PATCH 2/2]middle-end: Support recognition of three-way max/min.

2022-06-20 Thread Richard Biener via Gcc-patches
On Mon, 20 Jun 2022, Andrew Pinski wrote: > On Thu, Jun 16, 2022 at 4:11 AM Tamar Christina via Gcc-patches > wrote: > > > > Hi All, > > > > This patch adds support for three-way min/max recognition in phi-opts. > > > > Concretely for e.g. > > > > #include > > > > uint8_t three_min (uint8_t xc,

Re: [PATCH 2/2]middle-end: Support recognition of three-way max/min.

2022-06-20 Thread Andrew Pinski via Gcc-patches
On Thu, Jun 16, 2022 at 4:11 AM Tamar Christina via Gcc-patches wrote: > > Hi All, > > This patch adds support for three-way min/max recognition in phi-opts. > > Concretely for e.g. > > #include > > uint8_t three_min (uint8_t xc, uint8_t xm, uint8_t xy) { > uint8_t xk; > if (xc < xm)

RE: [PATCH 2/2]middle-end: Support recognition of three-way max/min.

2022-06-20 Thread Tamar Christina via Gcc-patches
> -Original Message- > From: Richard Biener > Sent: Monday, June 20, 2022 9:36 AM > To: Tamar Christina > Cc: gcc-patches@gcc.gnu.org; nd ; ja...@redhat.com > Subject: Re: [PATCH 2/2]middle-end: Support recognition of three-way > max/min. > > On Thu, 16 Jun

Re: [PATCH 2/2]middle-end: Support recognition of three-way max/min.

2022-06-20 Thread Richard Biener via Gcc-patches
On Thu, 16 Jun 2022, Tamar Christina wrote: > Hi All, > > This patch adds support for three-way min/max recognition in phi-opts. > > Concretely for e.g. > > #include > > uint8_t three_min (uint8_t xc, uint8_t xm, uint8_t xy) { > uint8_t xk; > if (xc < xm) { > xk = (uint8_t)

[PATCH 2/2]middle-end: Support recognition of three-way max/min.

2022-06-16 Thread Tamar Christina via Gcc-patches
Hi All, This patch adds support for three-way min/max recognition in phi-opts. Concretely for e.g. #include uint8_t three_min (uint8_t xc, uint8_t xm, uint8_t xy) { uint8_t xk; if (xc < xm) { xk = (uint8_t) (xc < xy ? xc : xy); } else { xk = (uint8_t) (xm < xy