Re: [PATCH 2/2] libstdc++: add constexpr stable_partition

2025-03-27 Thread Giuseppe D'Angelo
On 27/03/2025 13:24, Jonathan Wakely wrote: Sure thing; is the attached patch OK (on top of the other two)? Yes, looks good, thanks! Thank you, the 3 patches have now been committed to trunk. -- Giuseppe D'Angelo smime.p7s Description: S/MIME Cryptographic Signature

Re: [PATCH 2/2] libstdc++: add constexpr stable_partition

2025-03-27 Thread Jonathan Wakely
On Thu, 27 Mar 2025 at 12:20, Giuseppe D'Angelo wrote: > > Hello, > > Thank you for the review! > > On 27/03/2025 11:38, Jonathan Wakely wrote: > > With the inplace_merge and stable_partition patches approved, can you > > bump it again now? > > > > That would presumably resolve PR 119488. > > Sure

Re: [PATCH 2/2] libstdc++: add constexpr stable_partition

2025-03-27 Thread Giuseppe D'Angelo
Hello, Thank you for the review! On 27/03/2025 11:38, Jonathan Wakely wrote: With the inplace_merge and stable_partition patches approved, can you bump it again now? That would presumably resolve PR 119488. Sure thing; is the attached patch OK (on top of the other two)? Thank you, -- Giusep

Re: [PATCH 2/2] libstdc++: add constexpr stable_partition

2025-03-27 Thread Jonathan Wakely
On Mon, 17 Mar 2025 at 10:24, Giuseppe D'Angelo wrote: > > Hello, > > On 17/03/2025 10:03, Tomasz Kaminski wrote: > > It seems that the patch is causing *first to be moved twice into the > > same position. > > Good catch. I think I need to move it *back*, at least that's what > __uninitialized_con

Re: [PATCH] libstdc++: do not advertise full P2562R1 support (was: Re: [PATCH 2/2] libstdc++: add constexpr stable_partition)

2025-03-26 Thread Jonathan Wakely
On Wed, 26 Mar 2025 at 14:41, Giuseppe D'Angelo wrote: > > Hello, > > On 17/03/2025 11:22, Giuseppe D'Angelo wrote: > > > > PS: I've noticed that I have already accidentally bumped the FTM for > > constexpr stable sort; that's a bug as these two last algorithms were > > not inculded. I can decreme

[PATCH] libstdc++: do not advertise full P2562R1 support (was: Re: [PATCH 2/2] libstdc++: add constexpr stable_partition)

2025-03-26 Thread Giuseppe D'Angelo
Hello, On 17/03/2025 11:22, Giuseppe D'Angelo wrote: PS: I've noticed that I have already accidentally bumped the FTM for constexpr stable sort; that's a bug as these two last algorithms were not inculded. I can decrement it for the time being, then rebump it again? I didn't get an answer to

Re: [PATCH 2/2] libstdc++: add constexpr stable_partition

2025-03-17 Thread Giuseppe D'Angelo
Hello, On 17/03/2025 10:03, Tomasz Kaminski wrote: It seems that the patch is causing *first to be moved twice into the same position. Good catch. I think I need to move it *back*, at least that's what __uninitialized_construct_buf_dispatch seems to do. Given that we have constexpr allocati

Re: [PATCH 2/2] libstdc++: add constexpr stable_partition

2025-03-17 Thread Tomasz Kaminski
It seems that the patch is causing *first to be moved twice into the same position. *first is already moved in the __stable_partition_adaptive function: if (__len <= __buffer_size) { _ForwardIterator __result1 = __first; _Pointer __result2 = __buffer;

Re: [PATCH 2/2] libstdc++: add constexpr stable_partition

2025-03-15 Thread Giuseppe D'Angelo
Hello, I'm attaching the patch for constexpr stable_partition. Thank you, -- Giuseppe D'Angelo From 08b4984cb9a5b4ed3e904698b4a6997bde3088c3 Mon Sep 17 00:00:00 2001 From: Giuseppe D'Angelo Date: Sat, 15 Mar 2025 00:15:36 +0100 Subject: [PATCH 2/2] libstdc++: add constexpr s