Re: [PATCH 2/2] Windows libcpp: Make path-exists semantics more Posix-like

2015-08-18 Thread Ray Donnelly
On Fri, Apr 25, 2014 at 9:33 PM, Kai Tietz wrote: > 2014-04-25 21:24 GMT+02:00 Pedro Alves : >> On 04/25/2014 08:05 PM, Kai Tietz wrote: >>> 2014-04-25 18:53 GMT+02:00 Pedro Alves : On 04/19/2014 09:41 PM, Kai Tietz wrote: > Isn't this function something better placed in libiberty?

Re: [PATCH 2/2] Windows libcpp: Make path-exists semantics more Posix-like

2014-04-25 Thread Kai Tietz
2014-04-25 21:24 GMT+02:00 Pedro Alves : > On 04/25/2014 08:05 PM, Kai Tietz wrote: >> 2014-04-25 18:53 GMT+02:00 Pedro Alves : >>> On 04/19/2014 09:41 PM, Kai Tietz wrote: >>> Isn't this function something better placed in libiberty? Also this name looks a bit confusing. Wouldn't be a

Re: [PATCH 2/2] Windows libcpp: Make path-exists semantics more Posix-like

2014-04-25 Thread Pedro Alves
On 04/25/2014 08:05 PM, Kai Tietz wrote: > 2014-04-25 18:53 GMT+02:00 Pedro Alves : >> On 04/19/2014 09:41 PM, Kai Tietz wrote: >> >>> Isn't this function something better placed in libiberty? Also this name >>> looks a bit confusing. Wouldn't be a an function calling for _WIN32 case >>> also s

Re: [PATCH 2/2] Windows libcpp: Make path-exists semantics more Posix-like

2014-04-25 Thread Kai Tietz
2014-04-25 18:53 GMT+02:00 Pedro Alves : > On 04/19/2014 09:41 PM, Kai Tietz wrote: > >> Isn't this function something better placed in libiberty? Also this name >> looks a bit confusing. Wouldn't be a an function calling for _WIN32 case >> also stat, and just overrides the st_mode member, if i

Re: [PATCH 2/2] Windows libcpp: Make path-exists semantics more Posix-like

2014-04-25 Thread Pedro Alves
On 04/19/2014 08:40 PM, Ray Donnelly wrote: > Windows does a short-circuit lookup of paths containing > ../ which means that: > > exists/doesnotexist/../file > > is considered to exist, while on Posix it is considered > not to. The Posix semantics are relied upon when building > glibc so any path

Re: [PATCH 2/2] Windows libcpp: Make path-exists semantics more Posix-like

2014-04-25 Thread Pedro Alves
On 04/19/2014 09:41 PM, Kai Tietz wrote: > Isn't this function something better placed in libiberty? Also this name > looks a bit confusing. Wouldn't be a an function calling for _WIN32 case > also stat, and just overrides the st_mode member, if it is a link better. So > I would put this fun

Re: [PATCH 2/2] Windows libcpp: Make path-exists semantics more Posix-like

2014-04-19 Thread Kai Tietz
Hello Ray, - Original Message - > Windows does a short-circuit lookup of paths containing > ../ which means that: > > exists/doesnotexist/../file > > is considered to exist, while on Posix it is considered > not to. The Posix semantics are relied upon when building > glibc so any paths c

[PATCH 2/2] Windows libcpp: Make path-exists semantics more Posix-like

2014-04-19 Thread Ray Donnelly
Windows does a short-circuit lookup of paths containing ../ which means that: exists/doesnotexist/../file is considered to exist, while on Posix it is considered not to. The Posix semantics are relied upon when building glibc so any paths containing "../" are checked component wise. libcpp/