Re: [PATCH 2/2] Simplify and extend VRP edge-assertion code

2014-11-11 Thread Patrick Palka
On Tue, Nov 11, 2014 at 7:52 AM, Richard Biener wrote: > On Tue, Nov 11, 2014 at 4:52 AM, Patrick Palka wrote: >> This patch refactors the VRP edge-assertion code to make it always >> traverse SSA-name definitions in order to find suitable edge assertions >> to insert. Currently SSA-name definit

Re: [PATCH 2/2] Simplify and extend VRP edge-assertion code

2014-11-11 Thread Richard Biener
On Tue, Nov 11, 2014 at 1:56 PM, Andrew Pinski wrote: > On Tue, Nov 11, 2014 at 4:52 AM, Richard Biener > wrote: >> On Tue, Nov 11, 2014 at 4:52 AM, Patrick Palka wrote: >>> This patch refactors the VRP edge-assertion code to make it always >>> traverse SSA-name definitions in order to find suit

Re: [PATCH 2/2] Simplify and extend VRP edge-assertion code

2014-11-11 Thread Andrew Pinski
On Tue, Nov 11, 2014 at 4:52 AM, Richard Biener wrote: > On Tue, Nov 11, 2014 at 4:52 AM, Patrick Palka wrote: >> This patch refactors the VRP edge-assertion code to make it always >> traverse SSA-name definitions in order to find suitable edge assertions >> to insert. Currently SSA-name definit

Re: [PATCH 2/2] Simplify and extend VRP edge-assertion code

2014-11-11 Thread Richard Biener
On Tue, Nov 11, 2014 at 4:52 AM, Patrick Palka wrote: > This patch refactors the VRP edge-assertion code to make it always > traverse SSA-name definitions in order to find suitable edge assertions > to insert. Currently SSA-name definitions get traversed only when the > LHS of the original condit

Re: [PATCH 2/2] Simplify and extend VRP edge-assertion code

2014-11-11 Thread Patrick Palka
This patch failed regtesting -- and on second thought I'm not too confident that the refactoring is strictly an improvement so I will try to fix the main issue (that is to make the test vrp-1.c fail to compile) in a more direct way.

[PATCH 2/2] Simplify and extend VRP edge-assertion code

2014-11-10 Thread Patrick Palka
This patch refactors the VRP edge-assertion code to make it always traverse SSA-name definitions in order to find suitable edge assertions to insert. Currently SSA-name definitions get traversed only when the LHS of the original conditional is a bitwise AND or OR operation which seems like a stran