Re: [PATCH 2/2] Get rid of global state accesses in dominance.c

2015-08-18 Thread Richard Biener
On Sat, Aug 15, 2015 at 8:05 AM, Mikhail Maltsev wrote: > On 08/14/2015 11:02 AM, Richard Biener wrote: >> So the last time I did similar refactoring I wondered if we can somehow avoid >> the "noise" in non-IPA passes. Ideas I came up with are >> >> a) Inherit gimple/rtl pass classes from a cla

Re: [PATCH 2/2] Get rid of global state accesses in dominance.c

2015-08-14 Thread Mikhail Maltsev
On 08/14/2015 11:02 AM, Richard Biener wrote: > So the last time I did similar refactoring I wondered if we can somehow avoid > the "noise" in non-IPA passes. Ideas I came up with are > > a) Inherit gimple/rtl pass classes from a class which is initialized with > the > function the pass

Re: [PATCH 2/2] Get rid of global state accesses in dominance.c

2015-08-14 Thread David Malcolm
On Fri, 2015-08-14 at 12:25 -0600, Jeff Law wrote: > On 08/14/2015 02:02 AM, Richard Biener wrote: > > On Fri, Aug 14, 2015 at 3:04 AM, Mikhail Maltsev wrote: > >> The second part removes all global state accesses (i.e. accesses to cfun > >> and > >> it's members) from dominance.c. This requires

Re: [PATCH 2/2] Get rid of global state accesses in dominance.c

2015-08-14 Thread Jeff Law
On 08/14/2015 02:02 AM, Richard Biener wrote: On Fri, Aug 14, 2015 at 3:04 AM, Mikhail Maltsev wrote: The second part removes all global state accesses (i.e. accesses to cfun and it's members) from dominance.c. This requires to change lots of code, but I hope that this is a step in right direct

Re: [PATCH 2/2] Get rid of global state accesses in dominance.c

2015-08-14 Thread Richard Biener
On Fri, Aug 14, 2015 at 3:04 AM, Mikhail Maltsev wrote: > The second part removes all global state accesses (i.e. accesses to cfun and > it's members) from dominance.c. This requires to change lots of code, but I > hope > that this is a step in right direction (if my understanding of ongoing > re