Re: [PATCH 2/2] Add prime path coverage to gcc/gcov

2025-03-26 Thread Jørgen Kvalsvik
On 3/26/25 20:49, Jørgen Kvalsvik wrote: On 3/26/25 14:54, Jan Hubicka wrote: Hello, I apologize for late reply here.  I went thru the paper in gereater detail. While I originally though the usual path-profiling can be reasonably merged with the prime math profiling, so it is useful both for opt

Re: [PATCH 2/2] Add prime path coverage to gcc/gcov

2025-03-26 Thread Jørgen Kvalsvik
On 3/26/25 14:54, Jan Hubicka wrote: Hello, I apologize for late reply here. I went thru the paper in gereater detail. While I originally though the usual path-profiling can be reasonably merged with the prime math profiling, so it is useful both for optimizaiton and coverage testing, I think it

Re: [PATCH 2/2] Add prime path coverage to gcc/gcov

2025-03-26 Thread Jan Hubicka
Hello, I apologize for late reply here. I went thru the paper in gereater detail. While I originally though the usual path-profiling can be reasonably merged with the prime math profiling, so it is useful both for optimizaiton and coverage testing, I think it is better to not do that - the require

Re: [PATCH 2/2] Add prime path coverage to gcc/gcov

2025-01-31 Thread Jørgen Kvalsvik
Ping. Should I apply these changes and re-submit, or would you like to see more changes? Thanks, Jørgen On 1/5/25 22:06, Jørgen Kvalsvik wrote: On 1/5/25 20:53, Jørgen Kvalsvik wrote: On 1/5/25 20:25, Jan Hubicka wrote: ALGORITHM Since the numbers of paths grows so fast, we need a good algo

Re: [PATCH 2/2] Add prime path coverage to gcc/gcov

2025-01-05 Thread Jørgen Kvalsvik
On 1/5/25 20:53, Jørgen Kvalsvik wrote: On 1/5/25 20:25, Jan Hubicka wrote: ALGORITHM Since the numbers of paths grows so fast, we need a good algorithm. The naive approach of generating all paths and discarding redundancies (see reference_prime_paths in the diff) simply doesn't complete for ev

Re: [PATCH 2/2] Add prime path coverage to gcc/gcov

2025-01-05 Thread Jørgen Kvalsvik
On 1/5/25 20:25, Jan Hubicka wrote: ALGORITHM Since the numbers of paths grows so fast, we need a good algorithm. The naive approach of generating all paths and discarding redundancies (see reference_prime_paths in the diff) simply doesn't complete for even pretty simple functions with a few ten

Re: [PATCH 2/2] Add prime path coverage to gcc/gcov

2025-01-05 Thread Jan Hubicka
> ALGORITHM > > Since the numbers of paths grows so fast, we need a good > algorithm. The naive approach of generating all paths and discarding > redundancies (see reference_prime_paths in the diff) simply doesn't > complete for even pretty simple functions with a few ten thousand > paths (granted