Re: [PATCH 2/2, expand] make expand_builtin_strncmp more general

2016-11-08 Thread Aaron Sawdey
Richard,   Thanks for the review ... comments below. On Tue, 2016-11-08 at 13:36 +0100, Richard Biener wrote: > On Tue, Nov 1, 2016 at 11:29 PM, Aaron Sawdey > wrote: > > > > This patch adds code to expand_builtin_strncmp so it also attempts > > expansion via cmpstrnsi in the case where c_strlen

Re: [PATCH 2/2, expand] make expand_builtin_strncmp more general

2016-11-08 Thread Richard Biener
On Tue, Nov 1, 2016 at 11:29 PM, Aaron Sawdey wrote: > This patch adds code to expand_builtin_strncmp so it also attempts > expansion via cmpstrnsi in the case where c_strlen() returns NULL for > both string arguments, meaning that neither one is a constant. @@ -3929,61 +3929,85 @@ unsigned

Re: [PATCH 2/2, expand] make expand_builtin_strncmp more general

2016-11-04 Thread Aaron Sawdey
ChangeLog for this patch: 2016-11-03  Aaron Sawdey   * builtins.c (expand_builtin_strncmp): Attempt expansion of strncmp via cmpstrnsi even if neither string is constant. -- Aaron Sawdey, Ph.D. acsaw...@linux.vnet.ibm.com 050-2/C113 (507) 253-7520 home: 507/263-0782 IBM Linux

[PATCH 2/2, expand] make expand_builtin_strncmp more general

2016-11-01 Thread Aaron Sawdey
This patch adds code to expand_builtin_strncmp so it also attempts expansion via cmpstrnsi in the case where c_strlen() returns NULL for both string arguments, meaning that neither one is a constant. -- Aaron Sawdey, Ph.D. acsaw...@linux.vnet.ibm.com 050-2/C113 (507) 253-7520 home: 507/263-0782