Re: [PATCH 13/25] Create TARGET_DISABLE_CURRENT_VECTOR_SIZE

2018-10-01 Thread Richard Biener
On Fri, Sep 28, 2018 at 2:47 PM Andrew Stubbs wrote: > > On 19/09/18 14:45, Richard Biener wrote: > > So I guess the current_vector_size thing isn't too hard to get rid of, what > > you'd end up with would be using that size when you decide for vector > > types for loads (where there are no USEs w

Re: [PATCH 13/25] Create TARGET_DISABLE_CURRENT_VECTOR_SIZE

2018-09-28 Thread Andrew Stubbs
On 19/09/18 14:45, Richard Biener wrote: So I guess the current_vector_size thing isn't too hard to get rid of, what you'd end up with would be using that size when you decide for vector types for loads (where there are no USEs with vector types, so for example this would not apply to gathers).

Re: [PATCH 13/25] Create TARGET_DISABLE_CURRENT_VECTOR_SIZE

2018-09-19 Thread Richard Biener
On Tue, Sep 18, 2018 at 10:22 PM Andrew Stubbs wrote: > > On 18/09/18 12:21, Richard Sandiford wrote: > > Would the same be useful for GCN, or do you basically always > > want a VF of 64? > > Always 64; the vector size varies between 512-bit and 4096-bit, as needed. > > > None of this is a fundame

Re: [PATCH 13/25] Create TARGET_DISABLE_CURRENT_VECTOR_SIZE

2018-09-18 Thread Andrew Stubbs
On 18/09/18 12:21, Richard Sandiford wrote: Would the same be useful for GCN, or do you basically always want a VF of 64? Always 64; the vector size varies between 512-bit and 4096-bit, as needed. None of this is a fundamental restriction in theory. It's just something that needs to be fixed

Re: [PATCH 13/25] Create TARGET_DISABLE_CURRENT_VECTOR_SIZE

2018-09-18 Thread Richard Sandiford
Andrew Stubbs writes: > On 17/09/18 20:28, Richard Sandiford wrote: >>> This patch simply disables the cache so that it must ask the backend for the >>> preferred mode for every type. >> >> TBH I'm surprised this works. Obviously it does, otherwise you wouldn't >> have posted it, but it seems li

Re: [PATCH 13/25] Create TARGET_DISABLE_CURRENT_VECTOR_SIZE

2018-09-18 Thread Andrew Stubbs
On 17/09/18 20:28, Richard Sandiford wrote: This patch simply disables the cache so that it must ask the backend for the preferred mode for every type. TBH I'm surprised this works. Obviously it does, otherwise you wouldn't have posted it, but it seems like an accident. Various parts of the v

Re: [PATCH 13/25] Create TARGET_DISABLE_CURRENT_VECTOR_SIZE

2018-09-17 Thread Richard Sandiford
writes: > This feature probably ought to be reworked as a proper target hook, but I > would > like to know if this is the correct solution to the problem first. > > The problem is that GCN vectors have a fixed number of elements (64) and the > vector size varies with element size. E.g. V64QI is

[PATCH 13/25] Create TARGET_DISABLE_CURRENT_VECTOR_SIZE

2018-09-05 Thread ams
This feature probably ought to be reworked as a proper target hook, but I would like to know if this is the correct solution to the problem first. The problem is that GCN vectors have a fixed number of elements (64) and the vector size varies with element size. E.g. V64QI is 64 bytes and V64SI i