Re: [PATCH 1/8] OpenMP: metadirective tree data structures and front-end interfaces

2024-01-07 Thread Tobias Burnus
Hi Sandra, Tobias Burnus wrote: (I have now an errant to do - and will continue later with the review.) First, something a bit unrelated to this patch but affecting related code (quoting old, existing code): int omp_context_selector_matches (tree ctx) ... case O

Re: [PATCH 1/8] OpenMP: metadirective tree data structures and front-end interfaces

2024-01-06 Thread Tobias Burnus
Hi Sandra, given that it is "just" a revised patch of previously posted patch and (code wise not file wise) very localized to OpenMP code - and even there touching only 'declare ...' code in a simple way: I would be still fine to have it in GCC 14, but I want to give Jakub a chance to shout.

[PATCH 1/8] OpenMP: metadirective tree data structures and front-end interfaces

2024-01-06 Thread Sandra Loosemore
From: Kwok Cheung Yeung This patch adds the OMP_METADIRECTIVE tree node and shared tree-level support for manipulating metadirectives. It defines/exposes interfaces that will be used in subsequent patches that add front-end and middle-end support, but nothing generates these nodes yet. This pat