Re: [PATCH 1/5] Fix 101256: Wrong code due to range incorrect from PHI-OPT

2021-07-05 Thread Andrew Pinski via Gcc-patches
On Mon, Jul 5, 2021 at 4:26 AM Richard Biener via Gcc-patches wrote: > > On Sun, Jul 4, 2021 at 8:40 PM apinski--- via Gcc-patches > wrote: > > > > From: Andrew Pinski > > > > So the problem here is that replace_phi_edge_with_variable > > will copy range information to a already (not newly) defi

Re: [PATCH 1/5] Fix 101256: Wrong code due to range incorrect from PHI-OPT

2021-07-05 Thread Richard Biener via Gcc-patches
On Sun, Jul 4, 2021 at 8:40 PM apinski--- via Gcc-patches wrote: > > From: Andrew Pinski > > So the problem here is that replace_phi_edge_with_variable > will copy range information to a already (not newly) defined > ssa name. This causes wrong code later on. That's a bit too conservative I gue

[PATCH 1/5] Fix 101256: Wrong code due to range incorrect from PHI-OPT

2021-07-04 Thread apinski--- via Gcc-patches
From: Andrew Pinski So the problem here is that replace_phi_edge_with_variable will copy range information to a already (not newly) defined ssa name. This causes wrong code later on. This patch fixes the problem by requiring there to be statements that are to be placed before the conditional to