[PING^2] libgomp testsuite: Don't amend 'LD_LIBRARY_PATH' for system-provided HSA Runtime library (was: [PATCH 1/4] Remove build dependence on HSA run-time)

Hi! Ping^2. Grüße Thomas On 2022-04-28T15:48:13+0200, I wrote: > Hi! > > Ping. > > On 2022-04-06T11:20:47+0200, I wrote: >> On 2021-01-14T15:50:23+0100, I wrote: >>> I'm raising here an issue with HSA libgomp plugin code changes from a >>> while ago. While HSA is now no longer relevant for G

Re: libgomp GCN plugin: Clean up unused references to system-provided HSA Runtime library (was: [PATCH 1/4] Remove build dependence on HSA run-time)

On 06/04/2022 11:02, Thomas Schwinge wrote: Hi! On 2021-01-14T15:50:23+0100, I wrote: I'm raising here an issue with HSA libgomp plugin code changes from a while ago. While HSA is now no longer relevant for GCC master branch, the same code has also been copied into the GCN libgomp plugin. He

[PING] libgomp GCN plugin: Clean up unused references to system-provided HSA Runtime library (was: [PATCH 1/4] Remove build dependence on HSA run-time)

Hi! Ping. On 2022-04-06T12:02:08+0200, I wrote: > On 2021-01-14T15:50:23+0100, I wrote: >> I'm raising here an issue with HSA libgomp plugin code changes from a >> while ago. While HSA is now no longer relevant for GCC master branch, >> the same code has also been copied into the GCN libgomp plu

[PING] libgomp testsuite: Don't amend 'LD_LIBRARY_PATH' for system-provided HSA Runtime library (was: [PATCH 1/4] Remove build dependence on HSA run-time)

Hi! Ping. On 2022-04-06T11:20:47+0200, I wrote: > On 2021-01-14T15:50:23+0100, I wrote: >> I'm raising here an issue with HSA libgomp plugin code changes from a >> while ago. While HSA is now no longer relevant for GCC master branch, >> the same code has also been copied into the GCN libgomp plu

libgomp GCN plugin: Clean up unused references to system-provided HSA Runtime library (was: [PATCH 1/4] Remove build dependence on HSA run-time)

Hi! On 2021-01-14T15:50:23+0100, I wrote: > I'm raising here an issue with HSA libgomp plugin code changes from a > while ago. While HSA is now no longer relevant for GCC master branch, > the same code has also been copied into the GCN libgomp plugin. Here is another small clean-up patch (to ena

Re: libgomp testsuite: Don't amend 'LD_LIBRARY_PATH' for system-provided HSA Runtime library (was: [PATCH 1/4] Remove build dependence on HSA run-time)

On Wed, Apr 06, 2022 at 11:20:47AM +0200, Thomas Schwinge wrote: > However, the libgomp GCN plugin is unconditionally built against the > GCC-shipped 'include/hsa*.h' header files, and at run time does > 'dlopen("libhsa-runtime64.so.1")', so there is no system-provided HSA Runtime > library "used f

libgomp testsuite: Don't amend 'LD_LIBRARY_PATH' for system-provided HSA Runtime library (was: [PATCH 1/4] Remove build dependence on HSA run-time)

Hi! On 2021-01-14T15:50:23+0100, I wrote: > I'm raising here an issue with HSA libgomp plugin code changes from a > while ago. While HSA is now no longer relevant for GCC master branch, > the same code has also been copied into the GCN libgomp plugin. Here is another small clean-up patch (to ena

Re: [PATCH 1/4] Remove build dependence on HSA run-time

Hi! On 2021-01-19T12:37:56+0100, Martin Jambor wrote: > On Thu, Jan 14 2021, Thomas Schwinge wrote: >> I'm raising here an issue with HSA libgomp plugin code changes from a >> while ago. While HSA is now no longer relevant for GCC master branch, >> the same code has also been copied into the GCN

Re: [PATCH 1/4] Remove build dependence on HSA run-time

On 1/19/21 12:37 PM, Martin Jambor wrote: Right. From what I can tell at the moment, which is not much, the idea was to be able to load it even from a non-standard path and specify that path at configure time. If people think that is not useful and is actually harmful, I guess it can go. And

Re: [PATCH 1/4] Remove build dependence on HSA run-time

Hi Thomas, On Thu, Jan 14 2021, Thomas Schwinge wrote: > Hi! > > I'm raising here an issue with HSA libgomp plugin code changes from a > while ago. While HSA is now no longer relevant for GCC master branch, > the same code has also been copied into the GCN libgomp plugin. > > This is commit b8d89

Re: [PATCH 1/4] Remove build dependence on HSA run-time

Hi! I'm raising here an issue with HSA libgomp plugin code changes from a while ago. While HSA is now no longer relevant for GCC master branch, the same code has also been copied into the GCN libgomp plugin. This is commit b8d89b03db5f212919e4571671ebb4f5f8b1e19d (r242749) "Remove build dependen

Re: [PATCH 1/4] Remove build dependence on HSA run-time

On Tue, Nov 22, 2016 at 02:27:44PM +0100, Martin Jambor wrote: > I have basically copied what libgfortran did, with additional checking > for HAVE_UNISTD_H when attempting to implement secure_getenv in its > absence (which is maybe unnecessary but should not do any harm) and I > also needed to add

Re: [PATCH 1/4] Remove build dependence on HSA run-time

Hi, On Fri, Nov 18, 2016 at 11:23:10AM +0100, Jakub Jelinek wrote: > On Sun, Nov 13, 2016 at 08:02:41PM +0100, Martin Jambor wrote: > > @@ -143,6 +240,12 @@ init_enviroment_variables (void) > > suppress_host_fallback = true; > >else > > suppress_host_fallback = false; > > + > > + hs

Re: [PATCH 1/4] Remove build dependence on HSA run-time

On Sun, Nov 13, 2016 at 08:02:41PM +0100, Martin Jambor wrote: > @@ -143,6 +240,12 @@ init_enviroment_variables (void) > suppress_host_fallback = true; >else > suppress_host_fallback = false; > + > + hsa_runtime_lib = getenv ("HSA_RUNTIME_LIB"); > + if (hsa_runtime_lib == NULL) > +

[PATCH 1/4] Remove build dependence on HSA run-time

Hi, over the last year there have been only two changes to the HSA libgomp plugin, both are in the following patch. The first change allows running kernels in HSA grid with multiple dimensions. The second one changes the way the plugin calls hsa run-time to dynamic shared object loading, which h