Re: [PATCH 1/3] dwarf: Delete dead code.

2024-12-06 Thread Michal Jireš
On 11/27/24 2:59 PM, Richard Biener wrote: Did you test with -fdebug-types-section? This code should be still needed to generate the linkonce debug-type sections. Note it doesn't work (very well) when combined with LTO. I used the tests in testsuite and now I also tested it with nontrivia

Re: [PATCH 1/3] dwarf: Delete dead code.

2024-11-27 Thread Richard Biener
On Wed, Nov 6, 2024 at 3:35 PM Michal Jires wrote: > > This if branch checks for comdat_type_p (GTY union tag) and then uses > incorrect union variant die_id.die_symbol. There is no way to create > this combination of valid values even if we ignore the GTY. > > Running testsuite with abort() in br

[PATCH 1/3] dwarf: Delete dead code.

2024-11-06 Thread Michal Jires
This if branch checks for comdat_type_p (GTY union tag) and then uses incorrect union variant die_id.die_symbol. There is no way to create this combination of valid values even if we ignore the GTY. Running testsuite with abort() in branch confirms that it is never taken. gcc/ChangeLog: