Re: [PATCH 1/3] STABS: remove -gstabs and -gxcoff functionality

2022-11-10 Thread Martin Liška
On 11/10/22 15:12, Michael Matz wrote: Hello, On Thu, 10 Nov 2022, Martin Liška wrote: These changes are part of commit r13-2361-g7e0db0cdf01e9c885a29cb37415f5bc00d90c029 "STABS: remove -gstabs and -gxcoff functionality". What this does is remove these identifiers from "poisoning": /*

Re: [PATCH 1/3] STABS: remove -gstabs and -gxcoff functionality

2022-11-10 Thread Michael Matz via Gcc-patches
Hello, On Thu, 10 Nov 2022, Martin Liška wrote: > > These changes are part of > > commit r13-2361-g7e0db0cdf01e9c885a29cb37415f5bc00d90c029 > > "STABS: remove -gstabs and -gxcoff functionality". What this does is > > remove these identifiers from "poisoning": > > > > /* As the last action

Re: [PATCH 1/3] STABS: remove -gstabs and -gxcoff functionality

2022-11-10 Thread Martin Liška
On 11/4/22 10:32, Thomas Schwinge wrote: Hi! On 2022-09-01T12:05:23+0200, Martin Liška wrote: gcc/ChangeLog: --- a/gcc/system.h +++ b/gcc/system.h @@ -1009,8 +1009,7 @@ extern void fancy_abort (const char *, int, const char *) ASM_OUTPUT_DEFINE_LABEL_DIFFERENCE_SYMBOL HOST_WORDS_BIG_

Re: [PATCH 1/3] STABS: remove -gstabs and -gxcoff functionality

2022-11-04 Thread Thomas Schwinge
Hi! On 2022-09-01T12:05:23+0200, Martin Liška wrote: > gcc/ChangeLog: > --- a/gcc/system.h > +++ b/gcc/system.h > @@ -1009,8 +1009,7 @@ extern void fancy_abort (const char *, int, const char > *) > ASM_OUTPUT_DEFINE_LABEL_DIFFERENCE_SYMBOL HOST_WORDS_BIG_ENDIAN\ > OBJC_PROLOGUE

Re: Restore default 'sorry' 'TARGET_ASM_CONSTRUCTOR', 'TARGET_ASM_DESTRUCTOR' (was: [PATCH 1/3] STABS: remove -gstabs and -gxcoff functionality)

2022-11-04 Thread Thomas Schwinge
Hi! On 2022-11-04T10:04:59+0100, wrote: > On 2022-10-12T11:21:19+0200, Martin Liška wrote: >> On 10/10/22 16:19, Thomas Schwinge wrote: >>> attached >>> "Restore default 'sorry' 'TARGET_ASM_CONSTRUCTOR', 'TARGET_ASM_DESTRUCTOR'". > >> Thanks for the fix, really appreciated! > > Pushed to master

Restore default 'sorry' 'TARGET_ASM_CONSTRUCTOR', 'TARGET_ASM_DESTRUCTOR' (was: [PATCH 1/3] STABS: remove -gstabs and -gxcoff functionality)

2022-11-04 Thread Thomas Schwinge
Hi! On 2022-10-12T11:21:19+0200, Martin Liška wrote: > On 10/10/22 16:19, Thomas Schwinge wrote: >> attached >> "Restore default 'sorry' 'TARGET_ASM_CONSTRUCTOR', 'TARGET_ASM_DESTRUCTOR'". > Thanks for the fix, really appreciated! Pushed to master branch commit 4ee35c11fd328728c12f3e086ae016ca9

Re: Restore default 'sorry' 'TARGET_ASM_CONSTRUCTOR', 'TARGET_ASM_DESTRUCTOR' (was: [PATCH 1/3] STABS: remove -gstabs and -gxcoff functionality)

2022-10-12 Thread Martin Liška
On 10/10/22 16:19, Thomas Schwinge wrote: > Hi! > > On 2022-09-01T12:05:23+0200, Martin Liška wrote: >> Patch can bootstrap on x86_64-linux-gnu and survives regression tests. >> >> I've also built all cross compilers. > > First: thanks for that: clean up plus "built all cross compilers"! > > Bu

Re: Restore default 'sorry' 'TARGET_ASM_CONSTRUCTOR', 'TARGET_ASM_DESTRUCTOR' (was: [PATCH 1/3] STABS: remove -gstabs and -gxcoff functionality)

2022-10-10 Thread Richard Biener via Gcc-patches
On Mon, Oct 10, 2022 at 4:23 PM Tom de Vries wrote: > > On 10/10/22 16:19, Thomas Schwinge wrote: > > With that, OK to push? > > FWIW, nvptx change looks in the obvious category to me. Can you rename the functions as default_asm_out_* and instead of reviving dbxout.cc put them into targhooks.cc?

Re: Restore default 'sorry' 'TARGET_ASM_CONSTRUCTOR', 'TARGET_ASM_DESTRUCTOR' (was: [PATCH 1/3] STABS: remove -gstabs and -gxcoff functionality)

2022-10-10 Thread Tom de Vries via Gcc-patches
On 10/10/22 16:19, Thomas Schwinge wrote: With that, OK to push? FWIW, nvptx change looks in the obvious category to me. Thanks, - Tom

Restore default 'sorry' 'TARGET_ASM_CONSTRUCTOR', 'TARGET_ASM_DESTRUCTOR' (was: [PATCH 1/3] STABS: remove -gstabs and -gxcoff functionality)

2022-10-10 Thread Thomas Schwinge
Hi! On 2022-09-01T12:05:23+0200, Martin Liška wrote: > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > I've also built all cross compilers. First: thanks for that: clean up plus "built all cross compilers"! But yet, I've now tracked down an issue related to these chan

Re: [COMMITTED] Fix unused variable warning (was: [PATCH 1/3] STABS: remove -gstabs and -gxcoff functionality)

2022-09-14 Thread Martin Liška
On 9/14/22 14:19, Jan-Benedict Glaw wrote: > On Thu, 2022-09-01 12:05:23 +0200, Martin Liška wrote: >> Patch can bootstrap on x86_64-linux-gnu and survives regression tests. >> >> I've also built all cross compilers. >> >> Ready to be installed? >> Thanks, >> Martin >> >> gcc/ChangeLog: >> >>

[COMMITTED] Fix unused variable warning (was: [PATCH 1/3] STABS: remove -gstabs and -gxcoff functionality)

2022-09-14 Thread Jan-Benedict Glaw
On Thu, 2022-09-01 12:05:23 +0200, Martin Liška wrote: > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > I've also built all cross compilers. > > Ready to be installed? > Thanks, > Martin > > gcc/ChangeLog: > > * Makefile.in: Remove -gstabs option support, DBX-

Re: [PATCH 1/3] STABS: remove -gstabs and -gxcoff functionality

2022-09-07 Thread Martin Liška
On 9/6/22 19:00, David Edelsohn wrote: > * dwarf2out.cc (XCOFF_DEBUGGING_INFO): Likewise. > (HAVE_XCOFF_DWARF_EXTRAS): Likewise. > (output_fde): Likewise. > (output_call_frame_info): Likewise. > (have_macinfo): Likewise. > (add_AT_loc_list): Likewise. > (ad

Re: [PATCH 1/3] STABS: remove -gstabs and -gxcoff functionality

2022-09-06 Thread David Edelsohn via Gcc-patches
* dwarf2out.cc (XCOFF_DEBUGGING_INFO): Likewise. (HAVE_XCOFF_DWARF_EXTRAS): Likewise. (output_fde): Likewise. (output_call_frame_info): Likewise. (have_macinfo): Likewise. (add_AT_loc_list): Likewise. (add_AT_view_list): Likewise. (out

Re: [PATCH 1/3] STABS: remove -gstabs and -gxcoff functionality

2022-09-06 Thread David Edelsohn via Gcc-patches
I fully support the plan to remove stabs support, but this patch broke bootstrap on AIX. It seems rather bad policy to remove support for a feature without ensuring that the removal does not negatively impact the targets touched by the patch. I should have been explicitly copied on these patches

Re: [PATCH 1/3] STABS: remove -gstabs and -gxcoff functionality

2022-09-05 Thread Richard Biener via Gcc-patches
On Mon, Sep 5, 2022 at 9:59 AM Martin Liška wrote: > > On 9/2/22 10:54, Richard Biener wrote: > > On Fri, Sep 2, 2022 at 9:00 AM Martin Liška wrote: > >> > >> On 9/1/22 13:18, Richard Biener wrote: > >>> I presume WarnRemoved will diagnose use of -gstabs but not fail > >>> compilation. Will -gst

Re: [PATCH 1/3] STABS: remove -gstabs and -gxcoff functionality

2022-09-05 Thread Martin Liška
On 9/2/22 10:54, Richard Biener wrote: > On Fri, Sep 2, 2022 at 9:00 AM Martin Liška wrote: >> >> On 9/1/22 13:18, Richard Biener wrote: >>> I presume WarnRemoved will diagnose use of -gstabs but not fail >>> compilation. Will -gstabs then still enable -g (with the default debug >>> format)? >> >

Re: [PATCH 1/3] STABS: remove -gstabs and -gxcoff functionality

2022-09-02 Thread Richard Biener via Gcc-patches
On Fri, Sep 2, 2022 at 9:00 AM Martin Liška wrote: > > On 9/1/22 13:18, Richard Biener wrote: > > I presume WarnRemoved will diagnose use of -gstabs but not fail > > compilation. Will -gstabs then still enable -g (with the default debug > > format)? > > No, it won't set -g option. That was the u

Re: [PATCH 1/3] STABS: remove -gstabs and -gxcoff functionality

2022-09-02 Thread Martin Liška
On 9/1/22 13:18, Richard Biener wrote: I presume WarnRemoved will diagnose use of -gstabs but not fail compilation. Will -gstabs then still enable -g (with the default debug format)? No, it won't set -g option. Please followup with a gcc-13/changes.html entry. Sure. I notice we have VM