Re: [PATCH 1/2] shrink-wrap: Header hygiene

2015-09-10 Thread H.J. Lu
On Thu, Sep 10, 2015 at 12:09 PM, Segher Boessenkool wrote: > On Thu, Sep 10, 2015 at 11:49:33AM -0700, H.J. Lu wrote: >> On Thu, Sep 10, 2015 at 8:14 AM, Segher Boessenkool >> wrote: >> > This makes a few functions used only in shrink-wrap.c static, and >> > removes their declarations from shrin

Re: [PATCH 1/2] shrink-wrap: Header hygiene

2015-09-10 Thread Segher Boessenkool
On Thu, Sep 10, 2015 at 11:49:33AM -0700, H.J. Lu wrote: > On Thu, Sep 10, 2015 at 8:14 AM, Segher Boessenkool > wrote: > > This makes a few functions used only in shrink-wrap.c static, and > > removes their declarations from shrink-wrap.h . > It breaks build on i386: Sorry about that. I did gr

Re: [PATCH 1/2] shrink-wrap: Header hygiene

2015-09-10 Thread Jeff Law
On 09/10/2015 12:49 PM, H.J. Lu wrote: On Thu, Sep 10, 2015 at 8:14 AM, Segher Boessenkool wrote: This makes a few functions used only in shrink-wrap.c static, and removes their declarations from shrink-wrap.h . Bootstrapped and regression checked on powerpc64-linux. Is this okay for mainline

Re: [PATCH 1/2] shrink-wrap: Header hygiene

2015-09-10 Thread H.J. Lu
On Thu, Sep 10, 2015 at 8:14 AM, Segher Boessenkool wrote: > This makes a few functions used only in shrink-wrap.c static, and > removes their declarations from shrink-wrap.h . > > Bootstrapped and regression checked on powerpc64-linux. Is this > okay for mainline? > > > Segher > > > 2015-09-10

Re: [PATCH 1/2] shrink-wrap: Header hygiene

2015-09-10 Thread Bernd Schmidt
On 09/10/2015 05:14 PM, Segher Boessenkool wrote: > > * shrink-wrap.c (requires_stack_frame_p): Make static. > (prepare_shrink_wrap): Likewise. > (dup_block_and_redirect): Likewise. > * shrink-wrap.h: Remove declarations of those functions. This is ok. Bernd

[PATCH 1/2] shrink-wrap: Header hygiene

2015-09-10 Thread Segher Boessenkool
This makes a few functions used only in shrink-wrap.c static, and removes their declarations from shrink-wrap.h . Bootstrapped and regression checked on powerpc64-linux. Is this okay for mainline? Segher 2015-09-10 Segher Boessenkool * shrink-wrap.c (requires_stack_frame_p): Make