Re: [PATCH 1/2] rs6000: Emit vector fp comparison directly in rs6000_emit_vector_compare

2022-11-27 Thread Segher Boessenkool
Hi! Whoops I missed following up to this. On Mon, Nov 21, 2022 at 10:01:14AM +0800, Kewen.Lin wrote: > on 2022/11/18 23:10, Segher Boessenkool wrote: > > ge is nasty for float, it means something different with and without > > -ffast-math (with fast-math ge means not lt, le means not gt; both can

Re: [PATCH 1/2] rs6000: Emit vector fp comparison directly in rs6000_emit_vector_compare

2022-11-20 Thread Kewen.Lin via Gcc-patches
Hi Segher, on 2022/11/18 23:10, Segher Boessenkool wrote: > Hi! > > On Thu, Nov 17, 2022 at 02:59:00PM +0800, Kewen.Lin wrote: >> on 2022/11/17 02:44, Segher Boessenkool wrote: >>> On Wed, Nov 16, 2022 at 02:48:25PM +0800, Kewen.Lin wrote: * config/rs6000/rs6000.cc (rs6000_emit_vector_com

Re: [PATCH 1/2] rs6000: Emit vector fp comparison directly in rs6000_emit_vector_compare

2022-11-18 Thread Segher Boessenkool
Hi! On Thu, Nov 17, 2022 at 02:59:00PM +0800, Kewen.Lin wrote: > on 2022/11/17 02:44, Segher Boessenkool wrote: > > On Wed, Nov 16, 2022 at 02:48:25PM +0800, Kewen.Lin wrote: > >>* config/rs6000/rs6000.cc (rs6000_emit_vector_compare_inner): Remove > >>float only comparison operators. > >

Re: [PATCH 1/2] rs6000: Emit vector fp comparison directly in rs6000_emit_vector_compare

2022-11-16 Thread Kewen.Lin via Gcc-patches
Hi Segher, Thanks for the comments! on 2022/11/17 02:44, Segher Boessenkool wrote: > Hi! > > On Wed, Nov 16, 2022 at 02:48:25PM +0800, Kewen.Lin wrote: >> * config/rs6000/rs6000.cc (rs6000_emit_vector_compare_inner): Remove >> float only comparison operators. > > Why? Is that correct

Re: [PATCH 1/2] rs6000: Emit vector fp comparison directly in rs6000_emit_vector_compare

2022-11-16 Thread Segher Boessenkool
Hi! On Wed, Nov 16, 2022 at 02:48:25PM +0800, Kewen.Lin wrote: > * config/rs6000/rs6000.cc (rs6000_emit_vector_compare_inner): Remove > float only comparison operators. Why? Is that correct? Your mail says nothing about this :-( Is there any testcase that covers this, and that show

[PATCH 1/2] rs6000: Emit vector fp comparison directly in rs6000_emit_vector_compare

2022-11-15 Thread Kewen.Lin via Gcc-patches
Hi, All kinds of vector float comparison operators have been supported in one rtl comparison pattern as vector.md, we can just emit an rtx comparison insn with the given comparison operator in function rs6000_emit_vector_compare instead of checking and handling the reverse condition cases. This i