Re: [PATCH 1/2] ipa-cp: Avoid long linear searches through DECL_ARGUMENTS

2023-06-02 Thread Richard Biener via Gcc-patches
d shrink. > > > > But still using a vec<> looks like a straight-forward improvement here. > > Yeah, 64 parameters seems too tight. I guess a testcase in which we > would record information for that many parameters would be quite > artificial, but I can imagine somethi

Re: [PATCH 1/2] ipa-cp: Avoid long linear searches through DECL_ARGUMENTS

2023-05-31 Thread Martin Jambor
ss a testcase in which we would record information for that many parameters would be quite artificial, but I can imagine something like that in machine generated code. Below is the patch based on DECL_UIDs in a vector. The problem with std::pair is that it is not GC-friendly and the transformation

Re: [PATCH 1/2] ipa-cp: Avoid long linear searches through DECL_ARGUMENTS

2023-05-31 Thread Richard Biener via Gcc-patches
On Tue, May 30, 2023 at 4:21 PM Jan Hubicka wrote: > > > On Mon, May 29, 2023 at 6:20 PM Martin Jambor wrote: > > > > > > Hi, > > > > > > there have been concerns that linear searches through DECL_ARGUMENTS > > > that are often necessary to compute the index of a particular > > > PARM_DECL which

Re: [PATCH 1/2] ipa-cp: Avoid long linear searches through DECL_ARGUMENTS

2023-05-30 Thread Jan Hubicka via Gcc-patches
> On Mon, May 29, 2023 at 6:20 PM Martin Jambor wrote: > > > > Hi, > > > > there have been concerns that linear searches through DECL_ARGUMENTS > > that are often necessary to compute the index of a particular > > PARM_DECL which is the key to results of IPA-CP can happen often > > enough to be a

Re: [PATCH 1/2] ipa-cp: Avoid long linear searches through DECL_ARGUMENTS

2023-05-30 Thread Richard Biener via Gcc-patches
On Mon, May 29, 2023 at 6:20 PM Martin Jambor wrote: > > Hi, > > there have been concerns that linear searches through DECL_ARGUMENTS > that are often necessary to compute the index of a particular > PARM_DECL which is the key to results of IPA-CP can happen often > enough to be a compile time iss

[PATCH 1/2] ipa-cp: Avoid long linear searches through DECL_ARGUMENTS

2023-05-29 Thread Martin Jambor
Hi, there have been concerns that linear searches through DECL_ARGUMENTS that are often necessary to compute the index of a particular PARM_DECL which is the key to results of IPA-CP can happen often enough to be a compile time issue, especially if we plug the results into value numbering, as I in