Re: [PATCH 1/2] c++: subsumption of complex constraints [PR118069]

2024-12-19 Thread Jason Merrill
On 12/18/24 11:56 AM, Patrick Palka wrote: On Wed, 18 Dec 2024, Jason Merrill wrote: On 12/17/24 10:43 AM, Patrick Palka wrote: Bootstrapped and regtested on x86_64-pc-linux-gnu, does this look OK for trunk? Shall we also backport this to release branches? It's not a regression but seems like

Re: [PATCH 1/2] c++: subsumption of complex constraints [PR118069]

2024-12-18 Thread Patrick Palka
On Wed, 18 Dec 2024, Jason Merrill wrote: > On 12/17/24 10:43 AM, Patrick Palka wrote: > > Bootstrapped and regtested on x86_64-pc-linux-gnu, does this look > > OK for trunk? Shall we also backport this to release branches? > > It's not a regression but seems like a safe fix for an inconvenient >

Re: [PATCH 1/2] c++: subsumption of complex constraints [PR118069]

2024-12-18 Thread Jason Merrill
On 12/17/24 10:43 AM, Patrick Palka wrote: Bootstrapped and regtested on x86_64-pc-linux-gnu, does this look OK for trunk? Shall we also backport this to release branches? It's not a regression but seems like a safe fix for an inconvenient issue. OK for trunk and 14. I wonder about using __bu

Re: [PATCH 1/2] c++: subsumption of complex constraints [PR118069]

2024-12-17 Thread Patrick Palka
On Tue, 17 Dec 2024, Marek Polacek wrote: > On Tue, Dec 17, 2024 at 10:43:49AM -0500, Patrick Palka wrote: > > Bootstrapped and regtested on x86_64-pc-linux-gnu, does this look > > OK for trunk? Shall we also backport this to release branches? > > It's not a regression but seems like a safe fix f

Re: [PATCH 1/2] c++: subsumption of complex constraints [PR118069]

2024-12-17 Thread Marek Polacek
On Tue, Dec 17, 2024 at 10:43:49AM -0500, Patrick Palka wrote: > Bootstrapped and regtested on x86_64-pc-linux-gnu, does this look > OK for trunk? Shall we also backport this to release branches? > It's not a regression but seems like a safe fix for an inconvenient > issue. > > -- >8 -- > > For

[PATCH 1/2] c++: subsumption of complex constraints [PR118069]

2024-12-17 Thread Patrick Palka
Bootstrapped and regtested on x86_64-pc-linux-gnu, does this look OK for trunk? Shall we also backport this to release branches? It's not a regression but seems like a safe fix for an inconvenient issue. -- >8 -- For the testcase in the PR we hang during constraint normalization ultimately becau