Re: [PATCH 1/2] aarch64: Add FMA and FMAF intrinsics and tests

2025-03-15 Thread Ayan Shafqat
On Thu, Mar 13, 2025 at 08:31:24AM +, Kyrylo Tkachov wrote: > > I forgot during the review, but a patch needs a ChangeLog entry. > Could you provide one please to add to the commit log? > I have submitted the patch again in the mailing list: https://gcc.gnu.org/pipermail/gcc-patches/2025-Marc

Re: [PATCH 1/2] aarch64: Add FMA and FMAF intrinsics and tests

2025-03-13 Thread Kyrylo Tkachov
Hi Ayan, > On 11 Mar 2025, at 14:53, Ayan Shafqat wrote: > > Hello Kyrylo, > > On Tue, Mar 11, 2025 at 08:55:46AM +, Kyrylo Tkachov wrote: >> This looks ok to me. >> GCC is currently in a regression fixing stage so normally such a change >> would wait until stage 1 reopens. >> But this loo

Re: [PATCH 1/2] aarch64: Add FMA and FMAF intrinsics and tests

2025-03-11 Thread Ayan Shafqat
Hello Kyrylo, On Tue, Mar 11, 2025 at 08:55:46AM +, Kyrylo Tkachov wrote: > This looks ok to me. > GCC is currently in a regression fixing stage so normally such a change would > wait until stage 1 reopens. > But this looks like a pretty safe change so I’m not against taking it now. > Do you

Re: [PATCH 1/2] aarch64: Add FMA and FMAF intrinsics and tests

2025-03-11 Thread Kyrylo Tkachov
Hi Ayan, > On 9 Mar 2025, at 21:46, Ayan Shafqat wrote: > > This patch introduces inline definitions for the __fma and __fmaf > functions in arm_acle.h for AArch64 targets. These definitions rely on > __builtin_fma and __builtin_fmaf to ensure proper inlining and to meet > the ACLE requirements

[PATCH 1/2] aarch64: Add FMA and FMAF intrinsics and tests

2025-03-09 Thread Ayan Shafqat
This patch introduces inline definitions for the __fma and __fmaf functions in arm_acle.h for AArch64 targets. These definitions rely on __builtin_fma and __builtin_fmaf to ensure proper inlining and to meet the ACLE requirements [1]. The patch has been tested locally using a crosstool-NG sysroot