Re: [PATCH 1/2] Seperate -funroll-loops for GIMPLE unroller and RTL unroller

2020-05-28 Thread Jiufu Guo via Gcc-patches
Segher Boessenkool writes: > Hi! > > On Thu, May 28, 2020 at 04:22:16PM +0200, Richard Biener wrote: >> For GIMPLE level transforms I don't think targets have more knowledge >> than the middle-end. > > Yes, certainly. > >> In fact GIMPLE complete unrolling is about >> secondary effects, removing

Re: [PATCH 1/2] Seperate -funroll-loops for GIMPLE unroller and RTL unroller

2020-05-28 Thread Segher Boessenkool
Hi! On Thu, May 28, 2020 at 04:22:16PM +0200, Richard Biener wrote: > For GIMPLE level transforms I don't think targets have more knowledge > than the middle-end. Yes, certainly. > In fact GIMPLE complete unrolling is about > secondary effects, removing redundancies and abstraction. So IMHO > t

Re: [PATCH 1/2] Seperate -funroll-loops for GIMPLE unroller and RTL unroller

2020-05-28 Thread Richard Biener via Gcc-patches
On Tue, May 26, 2020 at 6:58 AM Jiufu Guo wrote: > > David Edelsohn writes: > > > On Mon, May 25, 2020 at 1:58 PM Richard Biener > > wrote: > >> > >> On May 25, 2020 7:40:00 PM GMT+02:00, Segher Boessenkool > >> wrote: > >> >On Mon, May 25, 2020 at 02:14:02PM +0200, Richard Biener wrote: > >>

Re: [PATCH 1/2] Seperate -funroll-loops for GIMPLE unroller and RTL unroller

2020-05-25 Thread Jiufu Guo via Gcc-patches
David Edelsohn writes: > On Mon, May 25, 2020 at 1:58 PM Richard Biener > wrote: >> >> On May 25, 2020 7:40:00 PM GMT+02:00, Segher Boessenkool >> wrote: >> >On Mon, May 25, 2020 at 02:14:02PM +0200, Richard Biener wrote: >> >> On Mon, May 25, 2020 at 1:10 PM guojiufu >> >wrote: >> >> Since a

Re: [PATCH 1/2] Seperate -funroll-loops for GIMPLE unroller and RTL unroller

2020-05-25 Thread Segher Boessenkool
On Mon, May 25, 2020 at 07:58:09PM +0200, Richard Biener wrote: > You folks made ppc specific hacks instead of a better design. Those now stand > in the way as well. But sure, simply do not expose the flag to the users, use > Var(flag_rtl_unroll_loops). My other points still stand. > > Feel free

Re: [PATCH 1/2] Seperate -funroll-loops for GIMPLE unroller and RTL unroller

2020-05-25 Thread David Edelsohn via Gcc-patches
On Mon, May 25, 2020 at 1:58 PM Richard Biener wrote: > > On May 25, 2020 7:40:00 PM GMT+02:00, Segher Boessenkool > wrote: > >On Mon, May 25, 2020 at 02:14:02PM +0200, Richard Biener wrote: > >> On Mon, May 25, 2020 at 1:10 PM guojiufu > >wrote: > >> Since a new flag is not needed to fix the r

Re: [PATCH 1/2] Seperate -funroll-loops for GIMPLE unroller and RTL unroller

2020-05-25 Thread Richard Biener via Gcc-patches
On May 25, 2020 7:40:00 PM GMT+02:00, Segher Boessenkool wrote: >On Mon, May 25, 2020 at 02:14:02PM +0200, Richard Biener wrote: >> On Mon, May 25, 2020 at 1:10 PM guojiufu >wrote: >> Since a new flag is not needed to fix the regression please avoid >> adding -fcomplete-unroll-loops. >> >> For

Re: [PATCH 1/2] Seperate -funroll-loops for GIMPLE unroller and RTL unroller

2020-05-25 Thread Segher Boessenkool
On Mon, May 25, 2020 at 02:14:02PM +0200, Richard Biener wrote: > On Mon, May 25, 2020 at 1:10 PM guojiufu wrote: > Since a new flag is not needed to fix the regression please avoid > adding -fcomplete-unroll-loops. > > For -frtl-unroll-loops you should be able to use Erm. That *is* a new comma

Re: [PATCH 1/2] Seperate -funroll-loops for GIMPLE unroller and RTL unroller

2020-05-25 Thread Richard Biener via Gcc-patches
On Mon, May 25, 2020 at 1:10 PM guojiufu wrote: > > Currently option -funroll-loops controls both GIMPLE unroler and > RTL unroller. It is not able to control GIMPLE cunroller and > RTL unroller independently. This patch introducing different flags > to control them seperately, and this also prov

[PATCH 1/2] Seperate -funroll-loops for GIMPLE unroller and RTL unroller

2020-05-25 Thread guojiufu via Gcc-patches
Currently option -funroll-loops controls both GIMPLE unroler and RTL unroller. It is not able to control GIMPLE cunroller and RTL unroller independently. This patch introducing different flags to control them seperately, and this also provide more freedom to tune one of them without affecting anot