Re: [PATCH 1/2] SVE intrinsics: Add strength reduction for division by constant.

2024-07-30 Thread Kyrylo Tkachov
Hi Jennifer, > On 30 Jul 2024, at 09:47, Jennifer Schmitz wrote: > > Dear Richard, > Thanks for the feedback. Great to see this patch approved! I made the changes > as suggested. > Best, > Jennifer > <0001-SVE-intrinsics-Add-strength-reduction-for-division-b.patch> Thanks, I’m okay with the pa

Re: [PATCH 1/2] SVE intrinsics: Add strength reduction for division by constant.

2024-07-30 Thread Jennifer Schmitz
Dear Richard, Thanks for the feedback. Great to see this patch approved! I made the changes as suggested. Best, Jennifer 0001-SVE-intrinsics-Add-strength-reduction-for-division-b.patch Description: Binary data > On 29 Jul 2024, at 22:55, Richard Sandiford wrote: > > External email: Use cauti

Re: [PATCH 1/2] SVE intrinsics: Add strength reduction for division by constant.

2024-07-29 Thread Richard Sandiford
Thanks for doing this. Jennifer Schmitz writes: > [...] > diff --git a/gcc/testsuite/gcc.target/aarch64/sve/acle/asm/div_s32.c > b/gcc/testsuite/gcc.target/aarch64/sve/acle/asm/div_s32.c > index c49ca1aa524..6500b64c41b 100644 > --- a/gcc/testsuite/gcc.target/aarch64/sve/acle/asm/div_s32.c > +++

Re: [PATCH 1/2] SVE intrinsics: Add strength reduction for division by constant.

2024-07-29 Thread Jennifer Schmitz
onst_1.c: New test. >> * gcc.target/aarch64/sve/div_const_1_run.c: Likewise. >> * gcc.target/aarch64/sve/acle/asm/div_s32.c: Adjust expected output. >> * gcc.target/aarch64/sve/acle/asm/div_s64.c: Likewise. >> >> From e8ffbab52ad7b9307cbfc9dbca4ef4d2

Re: [PATCH 1/2] SVE intrinsics: Add strength reduction for division by constant.

2024-07-17 Thread Richard Sandiford
d20e08804b Mon Sep 17 00:00:00 2001 > From: Jennifer Schmitz > Date: Tue, 16 Jul 2024 01:59:50 -0700 > Subject: [PATCH 1/2] SVE intrinsics: Add strength reduction for division by > constant. > > This patch folds signed SVE division where all divisor elements are the same > power o

[PATCH 1/2] SVE intrinsics: Add strength reduction for division by constant.

2024-07-17 Thread Jennifer Schmitz
This patch folds signed SVE division where all divisor elements are the same power of 2 to svasrd. Tests were added to check 1) whether the transform is applied, i.e. asrd is used, and 2) correctness for all possible input types for svdiv, predication, and a variety of values. As the transform is a