Re: [PATCH 1/2] LoongArch: Avoid RTL flag check failure in loongarch_classify_symbol

2022-08-25 Thread Xi Ruoyao via Gcc-patches
On Thu, 2022-08-25 at 16:29 +0800, Lulu Cheng wrote: > > 在 2022/8/24 下午10:03, Xi Ruoyao 写道: >   > > SYMBOL_REF_TLS_MODEL invokes SYMBOL_REF_FLAGS, and SYMBOL_REF_FLAGS > > invokes RTL_FLAG_CHECK1 and aborts when RTL code is not SYMBOL_REF. > > > > r13-1833 removed "gcc_assert (SYMBOL_REF_P (x))"

Re: [PATCH 1/2] LoongArch: Avoid RTL flag check failure in loongarch_classify_symbol

2022-08-25 Thread Lulu Cheng
在 2022/8/24 下午10:03, Xi Ruoyao 写道: SYMBOL_REF_TLS_MODEL invokes SYMBOL_REF_FLAGS, and SYMBOL_REF_FLAGS invokes RTL_FLAG_CHECK1 and aborts when RTL code is not SYMBOL_REF. r13-1833 removed "gcc_assert (SYMBOL_REF_P (x))" before invoking "SYMBOL_REF_TLS_MODEL (x)", indicating that it's now possi

[PATCH 1/2] LoongArch: Avoid RTL flag check failure in loongarch_classify_symbol

2022-08-24 Thread Xi Ruoyao via Gcc-patches
SYMBOL_REF_TLS_MODEL invokes SYMBOL_REF_FLAGS, and SYMBOL_REF_FLAGS invokes RTL_FLAG_CHECK1 and aborts when RTL code is not SYMBOL_REF. r13-1833 removed "gcc_assert (SYMBOL_REF_P (x))" before invoking "SYMBOL_REF_TLS_MODEL (x)", indicating that it's now possible that "x" is not a SYMBOL_REF. So w