Re: [PATCH 1/2] Introduce testsuite support to run Python tests

2017-08-03 Thread Pierre-Marie de Rodat
On 08/02/2017 08:43 PM, Jeff Law wrote: If it was trivial, then let's support 2.6. But if it's nontrivial, I'd support stepping to something more modern. It is trivial. I’ve done it locally. :-) -- Pierre-Marie de Rodat

Re: [PATCH 1/2] Introduce testsuite support to run Python tests

2017-08-02 Thread Jeff Law
On 07/26/2017 10:48 AM, David Malcolm wrote: > On Wed, 2017-07-26 at 18:35 +0200, Pierre-Marie de Rodat wrote: >> On 07/26/2017 06:25 PM, David Malcolm wrote: >>> str.format was introduced in Python 2.6, so presumably the minimum >>> python 2 version here is at least 2.6+; for Python 3 I believe it

Re: [PATCH 1/2] Introduce testsuite support to run Python tests

2017-07-27 Thread David Malcolm
On Thu, 2017-07-27 at 10:49 +0200, Pierre-Marie de Rodat wrote: > On 07/26/2017 06:48 PM, David Malcolm wrote: > > IIRC RHEL 6 has Python 2.6 as its /usr/bin/python (but Python 2.7 > > is > > available as a "software collection" add-on). > > > > I don't know if gcc as a project would want to suppo

Re: [PATCH 1/2] Introduce testsuite support to run Python tests

2017-07-27 Thread Pierre-Marie de Rodat
On 07/27/2017 10:50 AM, Matthias Klose wrote: you are unconditionally hard coding python as the interpreter, which on most distributions points to 2.7. Please check python3 as well and make that the preferred interpreter if available. python 2.7 is now EOL'd for 2020. Understood, thank you. I’

Re: [PATCH 1/2] Introduce testsuite support to run Python tests

2017-07-27 Thread Matthias Klose
you are unconditionally hard coding python as the interpreter, which on most distributions points to 2.7. Please check python3 as well and make that the preferred interpreter if available. python 2.7 is now EOL'd for 2020. Matthias On 26.07.2017 18:00, Pierre-Marie de Rodat wrote: > gcc/testsuit

Re: [PATCH 1/2] Introduce testsuite support to run Python tests

2017-07-27 Thread Pierre-Marie de Rodat
On 07/26/2017 06:48 PM, David Malcolm wrote: IIRC RHEL 6 has Python 2.6 as its /usr/bin/python (but Python 2.7 is available as a "software collection" add-on). I don't know if gcc as a project would want to support 2.6+ or simply 2.7 for Python 2. I don’t know neither: let’s wait for further f

Re: [PATCH 1/2] Introduce testsuite support to run Python tests

2017-07-26 Thread David Malcolm
On Wed, 2017-07-26 at 18:35 +0200, Pierre-Marie de Rodat wrote: > On 07/26/2017 06:25 PM, David Malcolm wrote: > > str.format was introduced in Python 2.6, so presumably the minimum > > python 2 version here is at least 2.6+; for Python 3 I believe it > > was > > present in Python 3.0 onwards. > >

Re: [PATCH 1/2] Introduce testsuite support to run Python tests

2017-07-26 Thread Pierre-Marie de Rodat
On 07/26/2017 06:25 PM, David Malcolm wrote: str.format was introduced in Python 2.6, so presumably the minimum python 2 version here is at least 2.6+; for Python 3 I believe it was present in Python 3.0 onwards. Hm… Python 2.6 is fairly old: last binary release was ages ago, last source relea

Re: [PATCH 1/2] Introduce testsuite support to run Python tests

2017-07-26 Thread David Malcolm
On Wed, 2017-07-26 at 18:00 +0200, Pierre-Marie de Rodat wrote: [...snip...] > diff --git a/gcc/testsuite/python/testutils.py > b/gcc/testsuite/python/testutils.py > new file mode 100644 > index 000..503105ad9d0 > --- /dev/null > +++ b/gcc/testsuite/python/testutils.py > @@ -0,0 +1,45 @@ >

[PATCH 1/2] Introduce testsuite support to run Python tests

2017-07-26 Thread Pierre-Marie de Rodat
gcc/testsuite/ * lib/gcc-python.exp: New test library. * python/testutils.py: New Python helper. --- gcc/testsuite/lib/gcc-python.exp | 95 +++ gcc/testsuite/python/testutils.py | 45 +++ 2 files changed, 140 insertions(+) crea