Re: [PATCH 1/2] Introduce prefetch-minimum stride option

2018-05-24 Thread Luis Machado
On 05/23/2018 10:57 PM, Jeff Law wrote: On 05/23/2018 04:50 PM, Luis Machado wrote: On 05/23/2018 07:42 PM, H.J. Lu wrote: On Wed, May 23, 2018 at 3:41 PM, H.J. Lu wrote: On Wed, May 23, 2018 at 3:35 PM, H.J. Lu wrote: Sorry. Does the following fix it for i686? Index: gcc/tree-ssa-loop

Re: [PATCH 1/2] Introduce prefetch-minimum stride option

2018-05-23 Thread Jeff Law
On 05/23/2018 04:50 PM, Luis Machado wrote: > On 05/23/2018 07:42 PM, H.J. Lu wrote: >> On Wed, May 23, 2018 at 3:41 PM, H.J. Lu wrote: >>> On Wed, May 23, 2018 at 3:35 PM, H.J. Lu wrote: >>> > > Sorry. Does the following fix it for i686? > Index: gcc/tree-ssa-loop-prefetch.

Re: [PATCH 1/2] Introduce prefetch-minimum stride option

2018-05-23 Thread Luis Machado
On 05/23/2018 07:42 PM, H.J. Lu wrote: On Wed, May 23, 2018 at 3:41 PM, H.J. Lu wrote: On Wed, May 23, 2018 at 3:35 PM, H.J. Lu wrote: Sorry. Does the following fix it for i686? Index: gcc/tree-ssa-loop-prefetch.c === --- gc

Re: [PATCH 1/2] Introduce prefetch-minimum stride option

2018-05-23 Thread H.J. Lu
On Wed, May 23, 2018 at 3:41 PM, H.J. Lu wrote: > On Wed, May 23, 2018 at 3:35 PM, H.J. Lu wrote: > >>> >>> Sorry. Does the following fix it for i686? >>> >> >> Index: gcc/tree-ssa-loop-prefetch.c >> === >> --- gcc/tree-ssa-loop-pref

Re: [PATCH 1/2] Introduce prefetch-minimum stride option

2018-05-23 Thread H.J. Lu
On Wed, May 23, 2018 at 3:35 PM, H.J. Lu wrote: > On Wed, May 23, 2018 at 3:29 PM, Luis Machado wrote: >> >> >> On 05/23/2018 05:01 PM, H.J. Lu wrote: >>> >>> On Tue, May 22, 2018 at 11:55 AM, Luis Machado >>> wrote: On 05/16/2018 08:18 AM, Luis Machado wrote: > > >>>

Re: [PATCH 1/2] Introduce prefetch-minimum stride option

2018-05-23 Thread H.J. Lu
On Wed, May 23, 2018 at 3:29 PM, Luis Machado wrote: > > > On 05/23/2018 05:01 PM, H.J. Lu wrote: >> >> On Tue, May 22, 2018 at 11:55 AM, Luis Machado >> wrote: >>> >>> >>> >>> On 05/16/2018 08:18 AM, Luis Machado wrote: On 05/16/2018 06:08 AM, Kyrill Tkachov wrote: >

Re: [PATCH 1/2] Introduce prefetch-minimum stride option

2018-05-23 Thread Luis Machado
On 05/23/2018 05:01 PM, H.J. Lu wrote: On Tue, May 22, 2018 at 11:55 AM, Luis Machado wrote: On 05/16/2018 08:18 AM, Luis Machado wrote: On 05/16/2018 06:08 AM, Kyrill Tkachov wrote: On 15/05/18 12:12, Luis Machado wrote: Hi, On 05/15/2018 06:37 AM, Kyrill Tkachov wrote: Hi Luis

Re: [PATCH 1/2] Introduce prefetch-minimum stride option

2018-05-23 Thread H.J. Lu
On Tue, May 22, 2018 at 11:55 AM, Luis Machado wrote: > > > On 05/16/2018 08:18 AM, Luis Machado wrote: >> >> >> >> On 05/16/2018 06:08 AM, Kyrill Tkachov wrote: >>> >>> >>> On 15/05/18 12:12, Luis Machado wrote: Hi, On 05/15/2018 06:37 AM, Kyrill Tkachov wrote: > > Hi

Re: [PATCH 1/2] Introduce prefetch-minimum stride option

2018-05-22 Thread Jeff Law
On 05/22/2018 12:55 PM, Luis Machado wrote: > > > On 05/16/2018 08:18 AM, Luis Machado wrote: >> >> >> On 05/16/2018 06:08 AM, Kyrill Tkachov wrote: >>> >>> On 15/05/18 12:12, Luis Machado wrote: Hi, On 05/15/2018 06:37 AM, Kyrill Tkachov wrote: > Hi Luis, > > On 14/05/

Re: [PATCH 1/2] Introduce prefetch-minimum stride option

2018-05-22 Thread Luis Machado
On 05/16/2018 08:18 AM, Luis Machado wrote: On 05/16/2018 06:08 AM, Kyrill Tkachov wrote: On 15/05/18 12:12, Luis Machado wrote: Hi, On 05/15/2018 06:37 AM, Kyrill Tkachov wrote: Hi Luis, On 14/05/18 22:18, Luis Machado wrote: Hi, Here's an updated version of the patch (now reverted)

Re: [PATCH 1/2] Introduce prefetch-minimum stride option

2018-05-16 Thread Luis Machado
On 05/16/2018 06:08 AM, Kyrill Tkachov wrote: On 15/05/18 12:12, Luis Machado wrote: Hi, On 05/15/2018 06:37 AM, Kyrill Tkachov wrote: Hi Luis, On 14/05/18 22:18, Luis Machado wrote: Hi, Here's an updated version of the patch (now reverted) that addresses the previous bootstrap problem

Re: [PATCH 1/2] Introduce prefetch-minimum stride option

2018-05-16 Thread Kyrill Tkachov
On 15/05/18 12:12, Luis Machado wrote: Hi, On 05/15/2018 06:37 AM, Kyrill Tkachov wrote: Hi Luis, On 14/05/18 22:18, Luis Machado wrote: Hi, Here's an updated version of the patch (now reverted) that addresses the previous bootstrap problem (signedness and long long/int conversion). I've

Re: [PATCH 1/2] Introduce prefetch-minimum stride option

2018-05-15 Thread Luis Machado
Hi, On 05/15/2018 06:37 AM, Kyrill Tkachov wrote: Hi Luis, On 14/05/18 22:18, Luis Machado wrote: Hi, Here's an updated version of the patch (now reverted) that addresses the previous bootstrap problem (signedness and long long/int conversion). I've checked that it bootstraps properly on b

Re: [PATCH 1/2] Introduce prefetch-minimum stride option

2018-05-15 Thread Kyrill Tkachov
Hi Luis, On 14/05/18 22:18, Luis Machado wrote: Hi, Here's an updated version of the patch (now reverted) that addresses the previous bootstrap problem (signedness and long long/int conversion). I've checked that it bootstraps properly on both aarch64-linux and x86_64-linux and that tests lo

Re: [PATCH 1/2] Introduce prefetch-minimum stride option

2018-05-14 Thread Luis Machado
suite and bootstrapped ok on aarch64-linux. Ok? >From e0207950a6d7793cdaceaa71fc5ada05a93dc1b3 Mon Sep 17 00:00:00 2001 From: Luis Machado Date: Thu, 21 Dec 2017 15:23:59 -0200 Subject: [PATCH 1/2] Introduce prefetch-minimum stride option This patch adds a new option to control the minimum st

Re: [PATCH 1/2] Introduce prefetch-minimum stride option

2018-05-07 Thread Luis Machado
On 05/07/2018 12:15 PM, H.J. Lu wrote: On Mon, May 7, 2018 at 7:09 AM, Luis Machado wrote: On 05/01/2018 03:30 PM, Jeff Law wrote: On 01/22/2018 06:46 AM, Luis Machado wrote: This patch adds a new option to control the minimum stride, for a memory reference, after which the loop prefetc

Re: [PATCH 1/2] Introduce prefetch-minimum stride option

2018-05-07 Thread H.J. Lu
On Mon, May 7, 2018 at 7:09 AM, Luis Machado wrote: > > > On 05/01/2018 03:30 PM, Jeff Law wrote: >> >> On 01/22/2018 06:46 AM, Luis Machado wrote: >>> >>> This patch adds a new option to control the minimum stride, for a memory >>> reference, after which the loop prefetch pass may issue software

Re: [PATCH 1/2] Introduce prefetch-minimum stride option

2018-05-07 Thread Luis Machado
On 05/01/2018 03:30 PM, Jeff Law wrote: On 01/22/2018 06:46 AM, Luis Machado wrote: This patch adds a new option to control the minimum stride, for a memory reference, after which the loop prefetch pass may issue software prefetch hints for. There are two motivations: * Make the pass less agg

Re: [PATCH 1/2] Introduce prefetch-minimum stride option

2018-05-01 Thread Jeff Law
On 01/22/2018 06:46 AM, Luis Machado wrote: > This patch adds a new option to control the minimum stride, for a memory > reference, after which the loop prefetch pass may issue software prefetch > hints for. There are two motivations: > > * Make the pass less aggressive, only issuing prefetch hint

Re: [PATCH 1/2] Introduce prefetch-minimum stride option

2018-01-23 Thread Luis Machado
Hi Kyrill, On 01/23/2018 07:32 AM, Kyrill Tkachov wrote: Hi Luis, On 22/01/18 13:46, Luis Machado wrote: This patch adds a new option to control the minimum stride, for a memory reference, after which the loop prefetch pass may issue software prefetch hints for. There are two motivations: * M

Re: [PATCH 1/2] Introduce prefetch-minimum stride option

2018-01-23 Thread Kyrill Tkachov
Hi Luis, On 22/01/18 13:46, Luis Machado wrote: This patch adds a new option to control the minimum stride, for a memory reference, after which the loop prefetch pass may issue software prefetch hints for. There are two motivations: * Make the pass less aggressive, only issuing prefetch hints f

[PATCH 1/2] Introduce prefetch-minimum stride option

2018-01-22 Thread Luis Machado
This patch adds a new option to control the minimum stride, for a memory reference, after which the loop prefetch pass may issue software prefetch hints for. There are two motivations: * Make the pass less aggressive, only issuing prefetch hints for bigger strides that are more likely to benefit f