Re: [PATCH 09/16] Split class rtx_reader into base_rtx_reader vs rtx_reader

2016-10-20 Thread Richard Sandiford
Bernd Schmidt writes: > On 10/18/2016 10:30 PM, David Malcolm wrote: >> >> I'm not in love with the names I chose in this patch. It does seem odd >> having an "rtx_reader" class that can't actually read hierarchical rtx. >> >> How about "md_reader" as the base class (with responsibility for the >

Re: [PATCH 09/16] Split class rtx_reader into base_rtx_reader vs rtx_reader

2016-10-19 Thread Bernd Schmidt
On 10/18/2016 10:30 PM, David Malcolm wrote: I'm not in love with the names I chose in this patch. It does seem odd having an "rtx_reader" class that can't actually read hierarchical rtx. How about "md_reader" as the base class (with responsibility for the things in read-md.o), and "rtx_reader

Re: [PATCH 09/16] Split class rtx_reader into base_rtx_reader vs rtx_reader

2016-10-18 Thread David Malcolm
[CCing Richard; this is re: https://gcc.gnu.org/ml/gcc-patches/2016-10/msg00273.html ] Essentially I want to split class rtx_reader into two parts: a base class covering the things implemented in read-md.o, and a subclass implemented in read-rtl.o. The motivation is that I want to make some o

Re: [PATCH 09/16] Split class rtx_reader into base_rtx_reader vs rtx_reader

2016-10-11 Thread Bernd Schmidt
On 10/05/2016 06:15 PM, David Malcolm wrote: - rtx_reader_ptr->get_top_level_filename ()); + base_rtx_reader_ptr->get_top_level_filename ()); I wonder if the number of changes could be minimized by retaining the name rtx_reader for the base class, and using something more speci

[PATCH 09/16] Split class rtx_reader into base_rtx_reader vs rtx_reader

2016-10-05 Thread David Malcolm
This moves read_rtx and friends into rtx_reader, and splits rtx_reader into two classes: class base_rtx_reader: has responsibility for reading chars, managing include files, top-level directives etc. It is the read-md.o part. class rtx_reader, a subclass, has the code for reading hierarchical rt