Re: [PATCH 09/13] AMD GCN libgomp plugin queue-full condition locking fix

2019-11-18 Thread Andrew Stubbs
On 15/11/2019 21:44, Julian Brown wrote: @@ -2732,13 +2732,9 @@ wait_for_queue_nonfull (struct goacc_asyncqueue *aq) { if (aq->queue_n == ASYNC_QUEUE_SIZE) { - pthread_mutex_lock (&aq->mutex); - /* Queue is full. Wait for it to not be full. */ while (aq->queue_n

[PATCH 09/13] AMD GCN libgomp plugin queue-full condition locking fix

2019-11-15 Thread Julian Brown
This patch corrects a possible race condition in locking for the asynchronous queue-full condition check in the AMD GCN libgomp plugin. OK? Julian ChangeLog libgomp/ * plugin/plugin-gcn.c (wait_for_queue_nonfull): Don't lock/unlock aq->mutex here. (queue_push_lau