Re: [PATCH 09/12] [i386] Add patterns and predicates foutline-msabi-xlouges

2017-05-03 Thread Uros Bizjak
On Wed, May 3, 2017 at 9:38 AM, Daniel Santos wrote: > On 05/03/2017 01:10 AM, Uros Bizjak wrote: >> >> The order of subexpressions of parallel in general does not matter. > > > Thanks, this makes things much clearer. > >>> Also, I'm wondering if there's anything wrong with calling ix86_gen_leave

Re: [PATCH 09/12] [i386] Add patterns and predicates foutline-msabi-xlouges

2017-05-03 Thread Daniel Santos
On 05/03/2017 01:10 AM, Uros Bizjak wrote: The order of subexpressions of parallel in general does not matter. Thanks, this makes things much clearer. Also, I'm wondering if there's anything wrong with calling ix86_gen_leave () and plucking the insns out of the generated parallel insn and mov

Re: [PATCH 09/12] [i386] Add patterns and predicates foutline-msabi-xlouges

2017-05-02 Thread Uros Bizjak
On Wed, May 3, 2017 at 12:16 AM, Daniel Santos wrote: >> I'd recommend that in the predicate, you check match_parallel from the >> bottom up, since subexpressions on the top are already matched, and >> you can have different number of subexpressions at the top. >> >> Uros. > > > OK, this all make

Re: [PATCH 09/12] [i386] Add patterns and predicates foutline-msabi-xlouges

2017-05-02 Thread Daniel Santos
Thank you for the review. On 05/01/2017 06:18 AM, Uros Bizjak wrote: On Thu, Apr 27, 2017 at 10:09 AM, Daniel Santos wrote: Adds the predicates save_multiple and restore_multiple to predicates.md, which are used by following patterns in sse.md: * save_multiple - insn that calls a save stub *

Re: [PATCH 09/12] [i386] Add patterns and predicates foutline-msabi-xlouges

2017-05-01 Thread Uros Bizjak
On Thu, Apr 27, 2017 at 10:09 AM, Daniel Santos wrote: > Adds the predicates save_multiple and restore_multiple to predicates.md, > which are used by following patterns in sse.md: > > * save_multiple - insn that calls a save stub > * restore_multiple - call_insn that calls a save stub and returns

[PATCH 09/12] [i386] Add patterns and predicates foutline-msabi-xlouges

2017-04-27 Thread Daniel Santos
Adds the predicates save_multiple and restore_multiple to predicates.md, which are used by following patterns in sse.md: * save_multiple - insn that calls a save stub * restore_multiple - call_insn that calls a save stub and returns to the function to allow a sibling call (which should typically