Re: [PATCH 09/10] RISC-V: Generate helpers for cbranch4 [PR 100266]

On Mon, Apr 26, 2021 at 4:40 PM Kito Cheng wrote: > > This patch is a good and simple improvement which could be an independent > patch. > > There is only 1 comment from me for this patch, could you also add @ > to cbranch pattern for floating mode, I would prefer make the > gen_cbranch4 could ha

Re: [PATCH 09/10] RISC-V: Generate helpers for cbranch4 [PR 100266]

This patch is a good and simple improvement which could be an independent patch. There is only 1 comment from me for this patch, could you also add @ to cbranch pattern for floating mode, I would prefer make the gen_cbranch4 could handle floating mode for consistency. So feel free to commit this

[PATCH 09/10] RISC-V: Generate helpers for cbranch4 [PR 100266]

On RISC-V we are facing the fact, that our conditional branches require Pmode conditions. Currently, we generate them explicitly with a check for Pmode and then calling the proper generator (i.e. gen_cbranchdi4 on RV64 and gen_cbranchsi4 on RV32). Let's make simplify this code by using gen_cbranch4