Re: [PATCH 08/10] Factorize condition insertion code out of build_check_stmt

2012-11-06 Thread Diego Novillo
On 2012-11-02 16:03 , Dodji Seketeli wrote: * asan.c (create_cond_insert_point_before_iter): Factorize out of ... (build_check_stmt): ... here. OK. Diego.

Re: [PATCH 08/10] Factorize condition insertion code out of build_check_stmt

2012-11-05 Thread Dodji Seketeli
Jakub Jelinek writes: > On Sat, Nov 03, 2012 at 12:03:45AM +0100, Dodji Seketeli wrote: >> + int fallthrough_probability = >> +then_more_likely_p >> +? PROB_VERY_UNLIKELY >> +: PROB_ALWAYS - PROB_VERY_UNLIKELY; > > Just a formatting nit, I think = needs to go on the next line, so > >

Re: [PATCH 08/10] Factorize condition insertion code out of build_check_stmt

2012-11-05 Thread Jakub Jelinek
On Sat, Nov 03, 2012 at 12:03:45AM +0100, Dodji Seketeli wrote: > + int fallthrough_probability = > +then_more_likely_p > +? PROB_VERY_UNLIKELY > +: PROB_ALWAYS - PROB_VERY_UNLIKELY; Just a formatting nit, I think = needs to go on the next line, so int fallthrough_probability =

[PATCH 08/10] Factorize condition insertion code out of build_check_stmt

2012-11-02 Thread Dodji Seketeli
This patch splits a new create_cond_insert_point_before_iter function out of build_check_stmt, to be used by a later patch. Tested by running cc1 -fasan on the test program below with and without the patch and by inspecting the gimple output to see that there is no change. void foo () { char fo