Re: Examples of gimple statement API (was Re: [PATCH 03/89] Introduce gimple_bind and use it for accessors.)

2014-04-28 Thread Richard Biener
On Fri, Apr 25, 2014 at 5:28 PM, David Malcolm wrote: > On Fri, 2014-04-25 at 10:37 +0200, Richard Biener wrote: >> On Thu, Apr 24, 2014 at 4:59 PM, David Malcolm wrote: >> > On Thu, 2014-04-24 at 09:09 -0400, Andrew MacLeod wrote: >> >> On 04/24/2014 04:33 AM, Richard Biener wrote: >> >> > On We

Re: Examples of gimple statement API (was Re: [PATCH 03/89] Introduce gimple_bind and use it for accessors.)

2014-04-25 Thread David Malcolm
On Fri, 2014-04-25 at 10:37 +0200, Richard Biener wrote: > On Thu, Apr 24, 2014 at 4:59 PM, David Malcolm wrote: > > On Thu, 2014-04-24 at 09:09 -0400, Andrew MacLeod wrote: > >> On 04/24/2014 04:33 AM, Richard Biener wrote: > >> > On Wed, Apr 23, 2014 at 11:23 PM, Jeff Law wrote: > >> >> On 04/2

Re: Examples of gimple statement API (was Re: [PATCH 03/89] Introduce gimple_bind and use it for accessors.)

2014-04-25 Thread Richard Biener
On Thu, Apr 24, 2014 at 4:59 PM, David Malcolm wrote: > On Thu, 2014-04-24 at 09:09 -0400, Andrew MacLeod wrote: >> On 04/24/2014 04:33 AM, Richard Biener wrote: >> > On Wed, Apr 23, 2014 at 11:23 PM, Jeff Law wrote: >> >> On 04/23/14 15:13, David Malcolm wrote: >> >>> On Wed, 2014-04-23 at 15:04

Re: Examples of gimple statement API (was Re: [PATCH 03/89] Introduce gimple_bind and use it for accessors.)

2014-04-24 Thread Michael Matz
Hi, On Thu, 24 Apr 2014, David Malcolm wrote: > Implicit naming > === > Several people have suggested that the "gimple_" prefix is redundant. Not generally though (for instance I find it redundant in the cast-method names, but _not_ in the global types). > Andrew MacLeod suggested

Examples of gimple statement API (was Re: [PATCH 03/89] Introduce gimple_bind and use it for accessors.)

2014-04-24 Thread David Malcolm
On Thu, 2014-04-24 at 09:09 -0400, Andrew MacLeod wrote: > On 04/24/2014 04:33 AM, Richard Biener wrote: > > On Wed, Apr 23, 2014 at 11:23 PM, Jeff Law wrote: > >> On 04/23/14 15:13, David Malcolm wrote: > >>> On Wed, 2014-04-23 at 15:04 -0600, Jeff Law wrote: > On 04/21/14 10:56, David Malco

Re: [PATCH 03/89] Introduce gimple_bind and use it for accessors.

2014-04-24 Thread Andrew MacLeod
On 04/24/2014 04:33 AM, Richard Biener wrote: On Wed, Apr 23, 2014 at 11:23 PM, Jeff Law wrote: On 04/23/14 15:13, David Malcolm wrote: On Wed, 2014-04-23 at 15:04 -0600, Jeff Law wrote: On 04/21/14 10:56, David Malcolm wrote: This updates all of the gimple_bind_* accessors in gimple.h from

Re: [PATCH 03/89] Introduce gimple_bind and use it for accessors.

2014-04-24 Thread Richard Biener
On Wed, Apr 23, 2014 at 11:23 PM, Jeff Law wrote: > On 04/23/14 15:13, David Malcolm wrote: >> >> On Wed, 2014-04-23 at 15:04 -0600, Jeff Law wrote: >>> >>> On 04/21/14 10:56, David Malcolm wrote: This updates all of the gimple_bind_* accessors in gimple.h from taking a plain g

Re: [PATCH 03/89] Introduce gimple_bind and use it for accessors.

2014-04-23 Thread Jeff Law
On 04/23/14 15:13, David Malcolm wrote: On Wed, 2014-04-23 at 15:04 -0600, Jeff Law wrote: On 04/21/14 10:56, David Malcolm wrote: This updates all of the gimple_bind_* accessors in gimple.h from taking a plain gimple to taking a gimple_bind (or const_gimple_bind), with the checking happening a

Re: [PATCH 03/89] Introduce gimple_bind and use it for accessors.

2014-04-23 Thread David Malcolm
On Wed, 2014-04-23 at 15:04 -0600, Jeff Law wrote: > On 04/21/14 10:56, David Malcolm wrote: > > This updates all of the gimple_bind_* accessors in gimple.h from taking a > > plain gimple to taking a gimple_bind (or const_gimple_bind), with the > > checking happening at the point of cast. > > > > V

Re: [PATCH 03/89] Introduce gimple_bind and use it for accessors.

2014-04-23 Thread Jeff Law
On 04/21/14 10:56, David Malcolm wrote: This updates all of the gimple_bind_* accessors in gimple.h from taking a plain gimple to taking a gimple_bind (or const_gimple_bind), with the checking happening at the point of cast. Various other types are strengthened from gimple to gimple_bind, and fr

[PATCH 03/89] Introduce gimple_bind and use it for accessors.

2014-04-21 Thread David Malcolm
This updates all of the gimple_bind_* accessors in gimple.h from taking a plain gimple to taking a gimple_bind (or const_gimple_bind), with the checking happening at the point of cast. Various other types are strengthened from gimple to gimple_bind, and from plain vec to vec. gcc/ * coret