Sam James writes:
> David Malcolm writes:
>
>> This patch adds a new dg-lint subdirectory below contrib, containing
>> a "dg-lint" script for detecting common mistakes made in our DejaGnu
>> tests.
>>
I should say: I don't think any of my comments are blockers at all,
they're really just furthe
Jakub Jelinek writes:
> On Wed, Mar 26, 2025 at 09:32:30PM +, Sam James wrote:
>> Right, we can extend it for 'dg-do known-actions' as well.
>
> I think that shouldn't be necessary.
>
> gcc-dg-test-1 should already complain about unexpected actions.
Ah, you're right. Thanks.
David Malcolm writes:
> On Wed, 2025-03-26 at 19:59 +0100, Jakub Jelinek wrote:
>> On Wed, Mar 26, 2025 at 02:34:43PM -0400, David Malcolm wrote:
>>
>> Thanks for working on this.
>> My python is very limited, so just adding some comments rather
>> than doing patch review.
>>
>> > +COMMON_MISSP
David Malcolm writes:
> This patch adds a new dg-lint subdirectory below contrib, containing
> a "dg-lint" script for detecting common mistakes made in our DejaGnu
> tests.
>
> Specifically, DejaGnu's dg.exp's dg-get-options has a regexp for
> detecting dg- directives
> https://git.savannah.gnu
On Wed, Mar 26, 2025 at 09:32:30PM +, Sam James wrote:
> Right, we can extend it for 'dg-do known-actions' as well.
I think that shouldn't be necessary.
gcc-dg-test-1 should already complain about unexpected actions.
Jakub
On Wed, 2025-03-26 at 19:59 +0100, Jakub Jelinek wrote:
> On Wed, Mar 26, 2025 at 02:34:43PM -0400, David Malcolm wrote:
>
> Thanks for working on this.
> My python is very limited, so just adding some comments rather
> than doing patch review.
>
> > +COMMON_MISSPELLINGS = {('dg_final', 'dg-final
On Wed, Mar 26, 2025 at 02:34:43PM -0400, David Malcolm wrote:
Thanks for working on this.
My python is very limited, so just adding some comments rather
than doing patch review.
> +COMMON_MISSPELLINGS = {('dg_final', 'dg-final')}
Does that catch just dg_final and not say dg_do or dg_error
or dg
This patch adds a new dg-lint subdirectory below contrib, containing
a "dg-lint" script for detecting common mistakes made in our DejaGnu
tests.
Specifically, DejaGnu's dg.exp's dg-get-options has a regexp for
detecting dg- directives
https://git.savannah.gnu.org/gitweb/?p=dejagnu.git;a=blob;f=l
