Re: [PATCH 01/10] Fix LRA bug

2018-12-14 Thread Andrew Stubbs
On 14/12/2018 10:04, Andrew Stubbs wrote: Anyway, this patch should not affect any use case that did not already have UB, so I'll get it committed shortly. Now done. Thanks for the review. Andrew

Re: [PATCH 01/10] Fix LRA bug

2018-12-14 Thread Andrew Stubbs
On 13/12/2018 23:49, Jeff Law wrote: OK. But be aware we may have to revisit and look more closely what what you're doing in your port if we stumble over more problems with reload changing the structure of your insns and causing problems in the process. Thanks. What's novel about this, I thin

Re: [PATCH 01/10] Fix LRA bug

2018-12-13 Thread Jeff Law
On 12/12/18 4:52 AM, Andrew Stubbs wrote: > > [This is new patch not included in the previously posted patch sets.] > > This patch fixes an ICE building libgfortran/random.c. > > The problem was an adddi3 instruction that had an eliminable frame pointer. > GCN adddi3 includes a match_scratch, wh

[PATCH 01/10] Fix LRA bug

2018-12-12 Thread Andrew Stubbs
[This is new patch not included in the previously posted patch sets.] This patch fixes an ICE building libgfortran/random.c. The problem was an adddi3 instruction that had an eliminable frame pointer. GCN adddi3 includes a match_scratch, which LRA substitutes with a REG, and checks if it can be