Re: [PATCH 0/7] Clean up widen mult even/odd

2012-07-17 Thread Richard Henderson
On 07/10/2012 02:09 AM, Jakub Jelinek wrote: > On Tue, Jul 10, 2012 at 10:22:44AM +0200, Richard Henderson wrote: >> I've not touched the interface to supportable_widening_operation, >> which is still prepared to return a CALL_EXPR and some decls. After >> this patch set it will never do so. I'm

Re: [PATCH 0/7] Clean up widen mult even/odd

2012-07-10 Thread Jakub Jelinek
On Tue, Jul 10, 2012 at 10:22:44AM +0200, Richard Henderson wrote: > I've not touched the interface to supportable_widening_operation, > which is still prepared to return a CALL_EXPR and some decls. After > this patch set it will never do so. I'm undecided as to whether we > ought to be prepared

Re: [PATCH 0/7] Clean up widen mult even/odd

2012-07-10 Thread Richard Guenther
On Tue, Jul 10, 2012 at 10:22 AM, Richard Henderson wrote: > I find it instructive that 4 of the 5 isas that actually implement > widening integer multiplication do have mult-widen-even as the isa > primitive (even if the -odd variant is missing). The fact that this > operation is implemented as

[PATCH 0/7] Clean up widen mult even/odd

2012-07-10 Thread Richard Henderson
I find it instructive that 4 of the 5 isas that actually implement widening integer multiplication do have mult-widen-even as the isa primitive (even if the -odd variant is missing). The fact that this operation is implemented as a set of builtins and target hooks has lead to disturbingly cookie-c