Re: [PATCH 0/4] Applying fix-its on behalf of the user to their code

2016-08-25 Thread Richard Biener
On Wed, Aug 24, 2016 at 11:52 PM, Manuel López-Ibáñez wrote: > On 24/08/16 14:56, Richard Biener wrote: >> >> You never typoed >> >> gcc t.c -o t.c >> >> ? ;) (I did ... :/) > > > With GCC >=5 > > $ gcc t.c -o t.c > gcc: fatal error: input file ‘t.c’ is the same as output file > compilation term

Re: [PATCH 0/4] Applying fix-its on behalf of the user to their code

2016-08-24 Thread Manuel López-Ibáñez
On 24/08/16 14:56, Richard Biener wrote: You never typoed gcc t.c -o t.c ? ;) (I did ... :/) With GCC >=5 $ gcc t.c -o t.c gcc: fatal error: input file ‘t.c’ is the same as output file compilation terminated. You are welcome ;-) Manuel.

Re: [PATCH 0/4] Applying fix-its on behalf of the user to their code

2016-08-24 Thread Richard Biener
On Wed, Aug 24, 2016 at 3:45 PM, Bernd Schmidt wrote: > On 08/24/2016 03:28 AM, David Malcolm wrote: > >> (B) -fdiagnostics-apply-fixits, which writes back the changes >> to the input files. > > > That sounds really scary, there's no way I'd personally ever enable > something like this. Do we have

Re: [PATCH 0/4] Applying fix-its on behalf of the user to their code

2016-08-24 Thread Bernd Schmidt
On 08/24/2016 03:28 AM, David Malcolm wrote: (B) -fdiagnostics-apply-fixits, which writes back the changes to the input files. That sounds really scary, there's no way I'd personally ever enable something like this. Do we have any data about what percentage of fixits actually correctly ident

Re: [PATCH 0/4] Applying fix-its on behalf of the user to their code

2016-08-24 Thread David Malcolm
On Wed, 2016-08-24 at 09:59 +0200, Richard Biener wrote: > On Wed, Aug 24, 2016 at 3:28 AM, David Malcolm > wrote: > > Currently our diagnostics subsystem can emit fix-it hints > > suggesting edits the user can make to their code to fix > > warnings/errors, > > but currently the user must make the

Re: [PATCH 0/4] Applying fix-its on behalf of the user to their code

2016-08-24 Thread Trevor Saunders
On Wed, Aug 24, 2016 at 09:59:18AM +0200, Richard Biener wrote: > On Wed, Aug 24, 2016 at 3:28 AM, David Malcolm wrote: > > Currently our diagnostics subsystem can emit fix-it hints > > suggesting edits the user can make to their code to fix warnings/errors, > > but currently the user must make th

Re: [PATCH 0/4] Applying fix-its on behalf of the user to their code

2016-08-24 Thread David Malcolm
On Tue, 2016-08-23 at 21:57 -0400, Eric Gallager wrote: > On 8/23/16, David Malcolm wrote: > > Currently our diagnostics subsystem can emit fix-it hints > > suggesting edits the user can make to their code to fix > > warnings/errors, > > but currently the user must make these edits manually [1]. >

Re: [PATCH 0/4] Applying fix-its on behalf of the user to their code

2016-08-24 Thread Richard Biener
On Wed, Aug 24, 2016 at 3:28 AM, David Malcolm wrote: > Currently our diagnostics subsystem can emit fix-it hints > suggesting edits the user can make to their code to fix warnings/errors, > but currently the user must make these edits manually [1]. > > The following patch kit adds two command-lin

Re: [PATCH 0/4] Applying fix-its on behalf of the user to their code

2016-08-23 Thread Eric Gallager
On 8/23/16, David Malcolm wrote: > Currently our diagnostics subsystem can emit fix-it hints > suggesting edits the user can make to their code to fix warnings/errors, > but currently the user must make these edits manually [1]. > > The following patch kit adds two command-line options with which

[PATCH 0/4] Applying fix-its on behalf of the user to their code

2016-08-23 Thread David Malcolm
Currently our diagnostics subsystem can emit fix-it hints suggesting edits the user can make to their code to fix warnings/errors, but currently the user must make these edits manually [1]. The following patch kit adds two command-line options with which we can make the changes on behalf of the us