Re: [PATCH 0/4] -Wmisleading-indentation

2015-10-30 Thread Mike Stump
On Oct 29, 2015, at 10:39 PM, Andi Kleen wrote: > David Malcolm writes: >> >> * adds -Wmisleading-indentation to -Wall > > I have doubts this is a good idea. I'm sure this will break > a bazillion packages which (misguidedly) ship with -Wall -Werror. > > Would be better to leave the user the

Re: [PATCH 0/4] -Wmisleading-indentation

2015-10-29 Thread Jeff Law
On 10/29/2015 11:39 PM, Andi Kleen wrote: David Malcolm writes: * adds -Wmisleading-indentation to -Wall I have doubts this is a good idea. I'm sure this will break a bazillion packages which (misguidedly) ship with -Wall -Werror. Would be better to leave the user the choice, given that

Re: [PATCH 0/4] -Wmisleading-indentation

2015-10-29 Thread Andi Kleen
David Malcolm writes: > > * adds -Wmisleading-indentation to -Wall I have doubts this is a good idea. I'm sure this will break a bazillion packages which (misguidedly) ship with -Wall -Werror. Would be better to leave the user the choice, given that such a thing was historically never checked

[PATCH 0/4] -Wmisleading-indentation

2015-10-29 Thread David Malcolm
The following patches: * tweak -Wmisleading-indentation to suppress a kind of false positive that occurred in three places in gcc's source tree, and * fix the two remaining truly misleadingly-indented places where the warning fires * adds -Wmisleading-indentation to -Wall Boot