Re: [PATCH #6/7] ifcombine across noncontiguous blocks

2024-11-06 Thread Richard Biener
On Mon, Nov 4, 2024 at 10:45 PM Alexandre Oliva wrote: > > On Nov 3, 2024, Richard Biener wrote: > > > On Sat, Nov 2, 2024 at 8:39 AM Alexandre Oliva wrote: > > >> I suppose we could get away without resetting flow info, but even if > >> guarding conditions become stricter, resetting flow info

Re: [PATCH #6/7] ifcombine across noncontiguous blocks

2024-11-04 Thread Alexandre Oliva
On Nov 3, 2024, Richard Biener wrote: > On Sat, Nov 2, 2024 at 8:39 AM Alexandre Oliva wrote: >> I suppose we could get away without resetting flow info, but even if >> guarding conditions become stricter, resetting flow info makes sense so >> that they're recomputed to reflect the guard chang

Re: [PATCH #6/7] ifcombine across noncontiguous blocks

2024-11-03 Thread Richard Biener
On Sat, Nov 2, 2024 at 8:39 AM Alexandre Oliva wrote: > > On Oct 30, 2024, Richard Biener wrote: > > > I think since you make the outer condition the short-circuiting one what's > > in > > the inner block isn't executed when it wasn't before the transform? So in > > fact you shouldn't need to p

Re: [PATCH #6/7] ifcombine across noncontiguous blocks

2024-11-02 Thread Alexandre Oliva
On Oct 30, 2024, Richard Biener wrote: > I think since you make the outer condition the short-circuiting one what's in > the inner block isn't executed when it wasn't before the transform? So in > fact you shouldn't need to process stmts in BB even? Only when the > outer condition is now uncond

Re: [PATCH #6/7] ifcombine across noncontiguous blocks (was: Re: [PATCH] fold fold_truth_andor field merging into ifcombine)

2024-10-30 Thread Richard Biener
On Fri, Oct 25, 2024 at 4:39 PM Alexandre Oliva wrote: > > > Rework ifcombine to support merging conditions from noncontiguous > blocks. This depends on earlier preparation changes. > > The function that attempted to ifcombine a block with its immediate > predecessor, tree_ssa_ifcombine_bb, now l

[PATCH #6/7] ifcombine across noncontiguous blocks (was: Re: [PATCH] fold fold_truth_andor field merging into ifcombine)

2024-10-25 Thread Alexandre Oliva
Rework ifcombine to support merging conditions from noncontiguous blocks. This depends on earlier preparation changes. The function that attempted to ifcombine a block with its immediate predecessor, tree_ssa_ifcombine_bb, now loops over dominating blocks eligible for ifcombine, attempting to c