Re: [PATCH #5/7] extend ifcombine_replace_cond to handle noncontiguous ifcombine

2024-11-01 Thread Alexandre Oliva
On Oct 30, 2024, Richard Biener wrote: > As you are only doing bitmap_set_bit/bitmap_bit_p consider doing >bitmap_tree_view (used); Ah, nice, I didn't know about this alternate representation. Thanks. > But we don't have any artificial limit on the number of stmts in the > middle block, r

Re: [PATCH #5/7] extend ifcombine_replace_cond to handle noncontiguous ifcombine (was: Re: [PATCH] fold fold_truth_andor field merging into ifcombine)

2024-10-30 Thread Richard Biener
On Fri, Oct 25, 2024 at 4:39 PM Alexandre Oliva wrote: > > > Prepare to handle noncontiguous ifcombine, introducing logic to modify > the outer condition when needed. There are two cases worth > mentioning: > > - when blocks are noncontiguous, we have to place the combined > condition in the ou

[PATCH #5/7] extend ifcombine_replace_cond to handle noncontiguous ifcombine (was: Re: [PATCH] fold fold_truth_andor field merging into ifcombine)

2024-10-25 Thread Alexandre Oliva
Prepare to handle noncontiguous ifcombine, introducing logic to modify the outer condition when needed. There are two cases worth mentioning: - when blocks are noncontiguous, we have to place the combined condition in the outer block to avoid pessimizing carefully crafted short-circuited te