Re: [PATCH]middle-end: Recursively check is_trivially_copyable_or_pair in vec.h

On Fri, Oct 06, 2023 at 02:23:06AM +, Tamar Christina wrote: > gcc/ChangeLog: > > * tree-if-conv.cc (INCLUDE_ALGORITHM): Remove. > (typedef struct ifcvt_arg_entry): New. > (cmp_arg_entry): New. > (gen_phi_arg_condition, gen_phi_nest_statement, > predicate_scalar_p

RE: [PATCH]middle-end: Recursively check is_trivially_copyable_or_pair in vec.h

> > On Thu, Oct 05, 2023 at 02:01:40PM +, Tamar Christina wrote: > > gcc/ChangeLog: > > > > * tree-if-conv.cc (INCLUDE_ALGORITHM): Remove. > > (typedef struct ifcvt_arg_entry): New. > > (cmp_arg_entry): New. > > (gen_phi_arg_condition, gen_phi_nest_statement, > > predicate_

Re: [PATCH]middle-end: Recursively check is_trivially_copyable_or_pair in vec.h

On Thu, Oct 05, 2023 at 02:01:40PM +, Tamar Christina wrote: > gcc/ChangeLog: > > * tree-if-conv.cc (INCLUDE_ALGORITHM): Remove. > (typedef struct ifcvt_arg_entry): New. > (cmp_arg_entry): New. > (gen_phi_arg_condition, gen_phi_nest_statement, > predicate_scalar_p

RE: [PATCH]middle-end: Recursively check is_trivially_copyable_or_pair in vec.h

> On Tue, Oct 03, 2023 at 11:41:01AM +, Tamar Christina wrote: > > > We have stablesort method instead of qsort but that would require > > > consistent ordering in the vector (std::sort doesn't ensure stable > > > sorting either). > > > > > > If it is a non-issue, the patch is ok with the above

Re: [PATCH]middle-end: Recursively check is_trivially_copyable_or_pair in vec.h

On Tue, Oct 03, 2023 at 11:41:01AM +, Tamar Christina wrote: > > We have stablesort method instead of > > qsort but that would require consistent ordering in the vector (std::sort > > doesn't ensure stable sorting either). > > > > If it is a non-issue, the patch is ok with the above nits fixed

RE: [PATCH]middle-end: Recursively check is_trivially_copyable_or_pair in vec.h

> -Original Message- > From: Jakub Jelinek > Sent: Tuesday, October 3, 2023 12:02 PM > To: Tamar Christina > Cc: gcc-patches@gcc.gnu.org; nd ; jwak...@redhat.com > Subject: Re: [PATCH]middle-end: Recursively check > is_trivially_copyable_or_pair in vec.h > >

Re: [PATCH]middle-end: Recursively check is_trivially_copyable_or_pair in vec.h

On Tue, Oct 03, 2023 at 10:27:16AM +, Tamar Christina wrote: > +/* Structure used to track meta-data on PHI arguments used to generate > + most efficient comparison sequence to slatten a PHI node. */ ^^^ typo (at least, never heard of this word, a

RE: [PATCH]middle-end: Recursively check is_trivially_copyable_or_pair in vec.h

> -Original Message- > From: Jakub Jelinek > Sent: Monday, October 2, 2023 2:21 PM > To: Tamar Christina > Cc: gcc-patches@gcc.gnu.org; nd ; jwak...@redhat.com > Subject: Re: [PATCH]middle-end: Recursively check > is_trivially_copyable_or_pair in vec.h > > On

RE: [PATCH]middle-end: Recursively check is_trivially_copyable_or_pair in vec.h

> -Original Message- > From: Jakub Jelinek > Sent: Monday, October 2, 2023 2:21 PM > To: Tamar Christina > Cc: gcc-patches@gcc.gnu.org; nd ; jwak...@redhat.com > Subject: Re: [PATCH]middle-end: Recursively check > is_trivially_copyable_or_pair in vec.h > > On

Re: [PATCH]middle-end: Recursively check is_trivially_copyable_or_pair in vec.h

On Mon, Oct 02, 2023 at 01:38:53PM +0100, Tamar Christina wrote: > Hi All, > > I recently committed a patch that uses a nested std::pair in the second > argument. > It temporarily adds a second ranking variable for sorting and then later > drops it. > > This hits the newly added assert in vec.h

[PATCH]middle-end: Recursively check is_trivially_copyable_or_pair in vec.h

Hi All, I recently committed a patch that uses a nested std::pair in the second argument. It temporarily adds a second ranking variable for sorting and then later drops it. This hits the newly added assert in vec.h. This assert made some relaxation for std::pair but doesn't allow this case thr