Re: [PING][PATCH]Partially fix PR61529, bound basic block frequency

2014-11-11 Thread Jeff Law
On 11/10/14 09:59, Renlin Li wrote: On 06/11/14 18:07, Renlin Li wrote: On 06/11/14 17:59, Teresa Johnson wrote: Thanks for fixing the test case. Can you also add the comment I suggested to the source change? Please add a comment that this is needed due to insane incoming frequencies. Sorr

Re: [PING][PATCH]Partially fix PR61529, bound basic block frequency

2014-11-10 Thread Teresa Johnson
Hi Renlin, Looks like Jeff already approved it: >Can you add a testcase please? With a testcase, this patch is OK for the >trunk. Teresa On Mon, Nov 10, 2014 at 8:59 AM, Renlin Li wrote: > On 06/11/14 18:07, Renlin Li wrote: >> >> On 06/11/14 17:59, Teresa Johnson wrote: >>> >>> Thanks for f

[PING][PATCH]Partially fix PR61529, bound basic block frequency

2014-11-10 Thread Renlin Li
On 06/11/14 18:07, Renlin Li wrote: On 06/11/14 17:59, Teresa Johnson wrote: Thanks for fixing the test case. Can you also add the comment I suggested to the source change? Please add a comment that this is needed due to insane incoming frequencies. Sorry, I mistakenly add it to the Change

Re: [PATCH]Partially fix PR61529, bound basic block frequency

2014-11-06 Thread Renlin Li
On 06/11/14 17:59, Teresa Johnson wrote: Thanks for fixing the test case. Can you also add the comment I suggested to the source change? Please add a comment that this is needed due to insane incoming frequencies. Sorry, I mistakenly add it to the ChangeLog. Should be correct now. x86_64-u

Re: [PATCH]Partially fix PR61529, bound basic block frequency

2014-11-06 Thread Teresa Johnson
Thanks for fixing the test case. Can you also add the comment I suggested to the source change? > Please add a comment that this is needed due to insane incoming frequencies. Thanks, Teresa On Thu, Nov 6, 2014 at 9:53 AM, Renlin Li wrote: > Hi Teresa, > > Thank you for the suggestion, updated!

Re: [PATCH]Partially fix PR61529, bound basic block frequency

2014-11-06 Thread Renlin Li
Hi Teresa, Thank you for the suggestion, updated! Please add a comment that this is needed due to insane incoming frequencies. The 'b' variable is uninitialized. Also, 'd' and 'a' may end up uninitialized depending on the initial value of 'b'. Please initialize these. Test case has been add

Re: [PATCH]Partially fix PR61529, bound basic block frequency

2014-11-06 Thread Teresa Johnson
On Thu, Nov 6, 2014 at 7:09 AM, Renlin Li wrote: > > Hi Jeff, > > Test case has been added. With the patch, both x86_64-unknown-linux-gnu and > aarch64-none-elf compile the test case successfully. > > Okay to commit? > > > On 04/11/14 21:59, Jeff Law wrote: >> >> On 11/03/14 08:29, Renlin Li wrote

Re: [PATCH]Partially fix PR61529, bound basic block frequency

2014-11-06 Thread Renlin Li
Hi Jeff, Test case has been added. With the patch, both x86_64-unknown-linux-gnu and aarch64-none-elf compile the test case successfully. Okay to commit? On 04/11/14 21:59, Jeff Law wrote: On 11/03/14 08:29, Renlin Li wrote: On 29/10/14 12:42, Teresa Johnson wrote: Hi Renlin, Are the inc

Re: [PATCH]Partially fix PR61529, bound basic block frequency

2014-11-04 Thread Jeff Law
On 11/03/14 08:29, Renlin Li wrote: On 29/10/14 12:42, Teresa Johnson wrote: Hi Renlin, Are the incoming edge counts or probabilities insane in this case? I guess the patch is ok if we need to do this to handle those incoming insanitiles. But I can't approve patches myself. Not really, it's j

Re: [PATCH]Partially fix PR61529, bound basic block frequency

2014-11-03 Thread Renlin Li
On 29/10/14 12:42, Teresa Johnson wrote: Hi Renlin, Are the incoming edge counts or probabilities insane in this case? I guess the patch is ok if we need to do this to handle those incoming insanitiles. But I can't approve patches myself. Not really, it's just a little bigger than the limit.

Re: [PATCH]Partially fix PR61529, bound basic block frequency

2014-10-29 Thread Teresa Johnson
Hi Renlin, Are the incoming edge counts or probabilities insane in this case? I guess the patch is ok if we need to do this to handle those incoming insanitiles. But I can't approve patches myself. However, this is a fix to code (r215739) committed after the ICE in the original bug report and in

[PATCH]Partially fix PR61529, bound basic block frequency

2014-10-29 Thread Renlin Li
Hi all, This is a simple patch to fix ICE in comment 2 of PR61529: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61529 Bound checking code is added to make sure the frequency is within legal range. As far as I have observed, r215830 patch fixes the glibc building ICE. And this patch should